Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken website on small screens #331

Merged
merged 3 commits into from Jan 17, 2022
Merged

Conversation

lictex
Copy link
Contributor

@lictex lictex commented Jan 12, 2022

#302

sidebar & navbar are collapsed into the hamburger menu

side effects / fixes note:

  • backdrop blurs now work in dark mode
  • code blocks will scroll instead of wrapping if overflowed
  • sidebar is pinned on desktop screen
  • slightly increased blur radius for better text readability
  • main text's max width is limited to around 900px
  • slightly reduced the font size of sidebar
  • added a small margin on index page

@lukechu10 lukechu10 added the A-website Area: Sycamore website label Jan 13, 2022
@lukechu10 lukechu10 linked an issue Jan 13, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Merging #331 (99542dd) into master (619c300) will decrease coverage by 0.10%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #331      +/-   ##
==========================================
- Coverage   73.15%   73.04%   -0.11%     
==========================================
  Files          40       40              
  Lines        5435     5443       +8     
==========================================
  Hits         3976     3976              
- Misses       1459     1467       +8     
Impacted Files Coverage Δ
website/src/main.rs 0.76% <0.00%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 619c300...99542dd. Read the comment docs.

@lukechu10
Copy link
Collaborator

Seems like I'll need to bump MSRV because of bumpalo. Thanks for the contribution!

@lukechu10 lukechu10 merged commit 56e8f04 into sycamore-rs:master Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-website Area: Sycamore website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation rendering on mobile
3 participants