Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call cleanup callbacks in map_keyed and map_indexed #357

Merged
merged 4 commits into from Feb 10, 2022
Merged

Call cleanup callbacks in map_keyed and map_indexed #357

merged 4 commits into from Feb 10, 2022

Conversation

lukechu10
Copy link
Collaborator

No description provided.

@lukechu10 lukechu10 added C-bug Category: bug, something isn't working A-reactivity Area: reactivity and state handling performance Performance related labels Feb 10, 2022
@github-actions
Copy link

github-actions bot commented Feb 10, 2022 •
edited 

Finished dev [unoptimized + debuginfo] target(s) in 0.04s
 Running `/home/runner/work/sycamore/sycamore/sycamore/target/debug/bench-diff ../../../../js-framework-benchmark/webdriver-ts/results.json`

Benchmark Report

  • wasm-bindgen: the performance goal
  • baseline: performance of sycamore-baseline (typically latest master)
  • update: performance of sycamore (typically recent changes)
  • diff: measures the improvement of update over the baseline
@@                         Performance Diff                          @@

##                       | wasm-bindgen | baseline |  update |  diff ##
#######################################################################
- 01_run1k               |       121.30 |   154.09 |  160.64 |   +4.25%
+ 02_replace1k           |       134.20 |   166.05 |  159.80 |   -3.76%
- 03_update10th1k_x16    |       328.73 |   343.92 |  356.53 |   +3.67%
+ 04_select1k            |        52.23 |    69.50 |   66.74 |   -3.96%
  05_swap1k              |        94.65 |    85.20 |   85.97 |   +0.91%
  06_remove-one-1k       |        32.04 |    33.32 |   32.35 |   -2.91%
+ 07_create10k           |      1260.10 |  1798.91 | 1737.21 |   -3.43%
+ 08_create1k-after1k_x2 |       307.51 |   356.31 |  338.86 |   -4.90%
- 09_clear1k_x8          |        83.40 |    96.69 |  107.84 |  +11.53%
  21_ready-memory        |         1.31 |     1.23 |    1.23 |   -0.00%
  22_run-memory          |         1.15 |     1.43 |    1.43 |   -0.11%
  23_update5-memory      |         1.15 |     1.44 |    1.44 |   +0.07%
+ 24_run5-memory         |         1.30 |     3.67 |    1.76 |  -52.23%
+ 25_run-clear-memory    |         1.21 |     3.68 |    1.08 |  -70.79%
+ 31_startup-ci          |      1883.17 |  1994.18 | 1918.85 |   -3.78%
+ 32_startup-bt          |        20.10 |    57.82 |   51.87 |  -10.30%
  34_startup-totalbytes  |       189.16 |   276.54 |  275.80 |   -0.27%

Workflow: 1821999802
Adding new commits will generate a new report

@codecov-commenter
Copy link

Codecov Report

Merging #357 (64603d4) into master (2cbf71c) will increase coverage by 0.24%.
The diff coverage is 98.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #357      +/-   ##
==========================================
+ Coverage   62.74%   62.99%   +0.24%     
==========================================
  Files          48       48              
  Lines        7357     7409      +52     
==========================================
+ Hits         4616     4667      +51     
- Misses       2741     2742       +1
Impacted Files Coverage Δ
packages/sycamore-reactive/src/iter.rs 97.41% <98.55%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cbf71c...64603d4. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Feb 10, 2022 •
edited 

Finished dev [unoptimized + debuginfo] target(s) in 0.04s
 Running `/home/runner/work/sycamore/sycamore/sycamore/target/debug/bench-diff ../../../../js-framework-benchmark/webdriver-ts/results.json`

Benchmark Report

  • wasm-bindgen: the performance goal
  • baseline: performance of sycamore-baseline (typically latest master)
  • update: performance of sycamore (typically recent changes)
  • diff: measures the improvement of update over the baseline
@@                         Performance Diff                          @@

##                       | wasm-bindgen | baseline |  update |  diff ##
#######################################################################
  01_run1k               |       104.96 |   135.00 |  135.19 |   +0.14%
+ 02_replace1k           |       110.35 |   148.45 |  140.66 |   -5.25%
  03_update10th1k_x16    |       358.91 |   354.54 |  364.81 |   +2.90%
- 04_select1k            |        53.48 |    57.91 |   61.24 |   +5.75%
  05_swap1k              |        80.81 |    83.70 |   81.31 |   -2.85%
  06_remove-one-1k       |        28.44 |    28.21 |   28.03 |   -0.65%
  07_create10k           |      1145.79 |  1592.62 | 1604.90 |   +0.77%
  08_create1k-after1k_x2 |       254.67 |   304.93 |  310.45 |   +1.81%
- 09_clear1k_x8          |        77.35 |    91.76 |  110.98 |  +20.95%
  21_ready-memory        |         1.31 |     1.23 |    1.23 |   -0.00%
  22_run-memory          |         1.14 |     1.48 |    1.45 |   -2.48%
  23_update5-memory      |         1.14 |     1.43 |    1.44 |   +0.82%
+ 24_run5-memory         |         1.30 |     3.67 |    1.76 |  -52.00%
+ 25_run-clear-memory    |         1.03 |     3.57 |    1.08 |  -69.83%
  31_startup-ci          |      1842.97 |  2039.17 | 1997.77 |   -2.03%
+ 32_startup-bt          |        13.88 |    58.66 |   33.37 |  -43.12%
  34_startup-totalbytes  |       189.16 |   276.54 |  275.80 |   -0.27%

Workflow: 1822061299
Adding new commits will generate a new report

@github-actions
Copy link

github-actions bot commented Feb 10, 2022 •
edited 

Finished dev [unoptimized + debuginfo] target(s) in 0.05s
 Running `/home/runner/work/sycamore/sycamore/sycamore/target/debug/bench-diff ../../../../js-framework-benchmark/webdriver-ts/results.json`

Benchmark Report

  • wasm-bindgen: the performance goal
  • baseline: performance of sycamore-baseline (typically latest master)
  • update: performance of sycamore (typically recent changes)
  • diff: measures the improvement of update over the baseline
@@                         Performance Diff                          @@

##                       | wasm-bindgen | baseline |  update |  diff ##
#######################################################################
  01_run1k               |       137.56 |   164.44 |  167.65 |   +1.95%
  02_replace1k           |       138.10 |   182.67 |  182.25 |   -0.23%
+ 03_update10th1k_x16    |       411.41 |   444.97 |  412.31 |   -7.34%
  04_select1k            |        78.62 |    74.14 |   75.44 |   +1.75%
+ 05_swap1k              |       113.44 |   125.98 |  112.07 |  -11.04%
- 06_remove-one-1k       |        38.54 |    36.54 |   37.82 |   +3.48%
  07_create10k           |      1298.79 |  1901.90 | 1863.49 |   -2.02%
  08_create1k-after1k_x2 |       317.67 |   385.54 |  388.18 |   +0.69%
- 09_clear1k_x8          |        86.72 |    98.65 |  121.70 |  +23.37%
+ 21_ready-memory        |         1.26 |     1.23 |    0.96 |  -22.13%
+ 22_run-memory          |         1.14 |     1.49 |    1.44 |   -3.40%
  23_update5-memory      |         1.15 |     1.44 |    1.44 |   +0.08%
+ 24_run5-memory         |         1.48 |     3.50 |    1.66 |  -52.54%
+ 25_run-clear-memory    |         1.03 |     3.79 |    1.22 |  -67.73%
- 31_startup-ci          |      1843.01 |  1999.29 | 2117.52 |   +5.91%
- 32_startup-bt          |        28.77 |    44.24 |   60.89 |  +37.62%
  34_startup-totalbytes  |       189.16 |   276.54 |  275.80 |   -0.27%

Workflow: 1822065474
Adding new commits will generate a new report

@github-actions
Copy link

github-actions bot commented Feb 10, 2022 •
edited 

Finished dev [unoptimized + debuginfo] target(s) in 0.04s
 Running `/home/runner/work/sycamore/sycamore/sycamore/target/debug/bench-diff ../../../../js-framework-benchmark/webdriver-ts/results.json`

Benchmark Report

  • wasm-bindgen: the performance goal
  • baseline: performance of sycamore-baseline (typically latest master)
  • update: performance of sycamore (typically recent changes)
  • diff: measures the improvement of update over the baseline
@@                         Performance Diff                          @@

##                       | wasm-bindgen | baseline |  update |  diff ##
#######################################################################
  01_run1k               |       101.11 |   130.32 |  131.58 |   +0.97%
  02_replace1k           |       105.93 |   136.81 |  136.90 |   +0.07%
+ 03_update10th1k_x16    |       248.72 |   260.74 |  241.57 |   -7.35%
  04_select1k            |        40.17 |    41.87 |   41.95 |   +0.18%
  05_swap1k              |        69.72 |    72.82 |   71.00 |   -2.51%
  06_remove-one-1k       |        25.73 |    26.14 |   26.07 |   -0.27%
  07_create10k           |      1062.33 |  1527.68 | 1497.53 |   -1.97%
  08_create1k-after1k_x2 |       233.47 |   287.83 |  279.88 |   -2.76%
- 09_clear1k_x8          |        66.60 |    85.09 |   97.37 |  +14.43%
  21_ready-memory        |         1.26 |     1.23 |    1.23 |   -0.00%
  22_run-memory          |         1.14 |     1.45 |    1.45 |   -0.23%
  23_update5-memory      |         1.14 |     1.43 |    1.45 |   +1.39%
+ 24_run5-memory         |         1.30 |     3.79 |    1.64 |  -56.81%
+ 25_run-clear-memory    |         1.03 |     3.61 |    1.08 |  -70.15%
  31_startup-ci          |      1841.17 |  2057.27 | 2030.53 |   -1.30%
- 32_startup-bt          |        11.83 |    45.18 |   48.53 |   +7.43%
  34_startup-totalbytes  |       189.16 |   276.54 |  275.80 |   -0.27%

Workflow: 1822068689
Adding new commits will generate a new report

@lukechu10 lukechu10 merged commit e0bb430 into master Feb 10, 2022
@lukechu10 lukechu10 deleted the keyed-dispose branch February 10, 2022 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-reactivity Area: reactivity and state handling C-bug Category: bug, something isn't working performance Performance related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lukechu10 @codecov-commenter