Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement AddAssign and friends for Signal #397

Merged
merged 4 commits into from Mar 21, 2022
Merged

Implement AddAssign and friends for Signal #397

merged 4 commits into from Mar 21, 2022

Conversation

lukechu10
Copy link
Collaborator

Closes #384

@lukechu10 lukechu10 added C-enhancement Category: new feature or improvement to existing feature A-reactivity Area: reactivity and state handling labels Mar 21, 2022
@lukechu10 lukechu10 added the performance Performance related label Mar 21, 2022
@github-actions
Copy link

github-actions bot commented Mar 21, 2022 •
edited 

Finished dev [unoptimized + debuginfo] target(s) in 0.05s
 Running `/home/runner/work/sycamore/sycamore/sycamore/target/debug/bench-diff ../../../../js-framework-benchmark/webdriver-ts/results.json`

Benchmark Report

  • wasm-bindgen: the performance goal
  • baseline: performance of sycamore-baseline (typically latest master)
  • update: performance of sycamore (typically recent changes)
  • diff: measures the improvement of update over the baseline
@@                         Performance Diff                          @@

##                       | wasm-bindgen | baseline |  update |  diff ##
#######################################################################
+ 01_run1k               |       143.05 |   191.40 |  183.58 |   -4.09%
+ 02_replace1k           |       151.34 |   215.49 |  201.54 |   -6.47%
+ 03_update10th1k_x16    |       385.64 |   421.58 |  388.57 |   -7.83%
+ 04_select1k            |        54.82 |    81.64 |   69.73 |  -14.58%
+ 05_swap1k              |        87.20 |   101.64 |   93.29 |   -8.22%
+ 06_remove-one-1k       |        32.84 |    34.06 |   31.31 |   -8.07%
  07_create10k           |      1610.96 |  2190.08 | 2135.03 |   -2.51%
  08_create1k-after1k_x2 |       345.62 |   430.49 |  425.59 |   -1.14%
- 09_clear1k_x8          |        99.17 |   132.96 |  143.37 |   +7.83%
  21_ready-memory        |         1.26 |     1.23 |    1.23 |   -0.00%
  22_run-memory          |         1.14 |     1.49 |    1.47 |   -1.49%
  23_update5-memory      |         1.14 |     1.72 |    1.73 |   +0.07%
  24_run5-memory         |         1.30 |     1.64 |    1.64 |   -0.11%
  25_run-clear-memory    |         1.21 |     1.07 |    1.10 |   +2.32%
- 31_startup-ci          |      1806.78 |  1997.22 | 2103.90 |   +5.34%
- 32_startup-bt          |        17.75 |    43.83 |   59.71 |  +36.25%
  34_startup-totalbytes  |       189.16 |   276.50 |  276.73 |   +0.08%

Workflow: 2018680383
Adding new commits will generate a new report

@codecov
Copy link

codecov bot commented Mar 21, 2022 •
edited

Codecov Report

Merging #397 (b242993) into master (a3bc95c) will increase coverage by 0.16%.
The diff coverage is 88.37%.

@@            Coverage Diff             @@
##           master     #397      +/-   ##
==========================================
+ Coverage   63.21%   63.37%   +0.16%     
==========================================
  Files          48       48              
  Lines        7742     7779      +37     
==========================================
+ Hits         4894     4930      +36     
- Misses       2848     2849       +1
Impacted Files Coverage Δ
packages/sycamore/src/generic_node/dom_node.rs 0.00% <0.00%> (ø)
packages/sycamore/src/generic_node/hydrate_dom.rs 0.00% <0.00%> (ø)
packages/sycamore/src/generic_node/mod.rs 100.00% <ø> (ø)
packages/sycamore-macro/src/view/codegen.rs 96.26% <100.00%> (ø)
packages/sycamore-reactive/src/signal.rs 86.90% <100.00%> (+1.70%) ⬆️
packages/sycamore/src/generic_node/ssr_node.rs 76.44% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3bc95c...b242993. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Mar 21, 2022 •
edited 

Finished dev [unoptimized + debuginfo] target(s) in 0.04s
 Running `/home/runner/work/sycamore/sycamore/sycamore/target/debug/bench-diff ../../../../js-framework-benchmark/webdriver-ts/results.json`

Benchmark Report

  • wasm-bindgen: the performance goal
  • baseline: performance of sycamore-baseline (typically latest master)
  • update: performance of sycamore (typically recent changes)
  • diff: measures the improvement of update over the baseline
@@                         Performance Diff                          @@

##                       | wasm-bindgen | baseline |  update |  diff ##
#######################################################################
  01_run1k               |       111.29 |   138.11 |  137.94 |   -0.12%
  02_replace1k           |       117.19 |   153.18 |  153.25 |   +0.05%
+ 03_update10th1k_x16    |       357.13 |   386.46 |  372.67 |   -3.57%
- 04_select1k            |        57.62 |    60.59 |   66.48 |   +9.71%
- 05_swap1k              |        89.03 |    88.84 |   93.53 |   +5.28%
  06_remove-one-1k       |        29.92 |    31.14 |   31.28 |   +0.43%
- 07_create10k           |      1129.20 |  1515.50 | 1604.95 |   +5.90%
  08_create1k-after1k_x2 |       267.82 |   300.94 |  304.34 |   +1.13%
- 09_clear1k_x8          |        71.37 |    97.43 |  102.53 |   +5.23%
+ 21_ready-memory        |         1.26 |     1.23 |    0.96 |  -22.21%
  22_run-memory          |         1.14 |     1.49 |    1.49 |   +0.08%
- 23_update5-memory      |         1.15 |     1.49 |    1.72 |  +15.36%
  24_run5-memory         |         1.30 |     1.64 |    1.65 |   +0.44%
+ 25_run-clear-memory    |         1.03 |     1.22 |    1.07 |  -12.29%
  31_startup-ci          |      1871.21 |  1945.10 | 1901.37 |   -2.25%
+ 32_startup-bt          |        13.23 |    41.48 |   33.05 |  -20.33%
  34_startup-totalbytes  |       189.16 |   276.50 |  276.73 |   +0.08%

Workflow: 2018856436
Adding new commits will generate a new report

@github-actions
Copy link

github-actions bot commented Mar 21, 2022 •
edited 

Finished dev [unoptimized + debuginfo] target(s) in 0.05s
 Running `/home/runner/work/sycamore/sycamore/sycamore/target/debug/bench-diff ../../../../js-framework-benchmark/webdriver-ts/results.json`

Benchmark Report

  • wasm-bindgen: the performance goal
  • baseline: performance of sycamore-baseline (typically latest master)
  • update: performance of sycamore (typically recent changes)
  • diff: measures the improvement of update over the baseline
@@                         Performance Diff                          @@

##                       | wasm-bindgen | baseline |  update |  diff ##
#######################################################################
  01_run1k               |       138.43 |   176.05 |  173.05 |   -1.70%
+ 02_replace1k           |       144.27 |   204.29 |  194.42 |   -4.83%
  03_update10th1k_x16    |       583.43 |   631.58 |  621.95 |   -1.52%
+ 04_select1k            |        73.02 |   103.60 |   76.49 |  -26.17%
- 05_swap1k              |       148.20 |   137.72 |  146.22 |   +6.17%
  06_remove-one-1k       |        37.42 |    42.75 |   42.79 |   +0.08%
  07_create10k           |      1466.44 |  2153.90 | 2105.33 |   -2.25%
  08_create1k-after1k_x2 |       369.17 |   434.47 |  432.23 |   -0.51%
- 09_clear1k_x8          |       118.07 |   158.55 |  164.77 |   +3.93%
  21_ready-memory        |         1.26 |     1.23 |    1.23 |   -0.00%
  22_run-memory          |         1.14 |     1.48 |    1.49 |   +0.39%
  23_update5-memory      |         1.14 |     1.72 |    1.73 |   +0.13%
  24_run5-memory         |         1.30 |     1.65 |    1.67 |   +0.82%
  25_run-clear-memory    |         1.03 |     1.10 |    1.07 |   -2.27%
+ 31_startup-ci          |      1908.72 |  2138.84 | 2000.49 |   -6.47%
+ 32_startup-bt          |        48.56 |    53.20 |   49.22 |   -7.48%
  34_startup-totalbytes  |       189.16 |   276.50 |  276.73 |   +0.08%

Workflow: 2018882294
Adding new commits will generate a new report

@lukechu10 lukechu10 merged commit cfd697b into master Mar 21, 2022
@lukechu10 lukechu10 deleted the signal-feat branch March 21, 2022 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-reactivity Area: reactivity and state handling C-enhancement Category: new feature or improvement to existing feature performance Performance related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement AddAssign and friends for Signal<T> where T: Copy
1 participant
@lukechu10