Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MSRV to 1.63.0 and remove some unsafes #470

Merged
merged 5 commits into from Aug 21, 2022
Merged

Conversation

lukechu10
Copy link
Collaborator

@lukechu10 lukechu10 commented Aug 21, 2022

A lot of unsafe code was removed from sycamore-reactive and sycamore-core with the new "NLL" feature stabilized in Rust 1.63.0

Also removes Children::call_with_bounded_scope since it is exactly the same as Children::call.

@lukechu10 lukechu10 added the BREAKING CHANGE Breaking changes introduced in this PR label Aug 21, 2022
@codecov
Copy link

codecov bot commented Aug 21, 2022

Codecov Report

Merging #470 (9ea535c) into master (2bb51c3) will decrease coverage by 0.10%.
The diff coverage is 63.15%.

@@            Coverage Diff             @@
##           master     #470      +/-   ##
==========================================
- Coverage   64.54%   64.43%   -0.11%     
==========================================
  Files          52       52              
  Lines        8404     8387      -17     
==========================================
- Hits         5424     5404      -20     
- Misses       2980     2983       +3     
Impacted Files Coverage Δ
packages/sycamore-core/src/component.rs 68.18% <ø> (+8.18%) ⬆️
packages/sycamore-macro/src/view/mod.rs 60.00% <ø> (ø)
website/src/main.rs 0.55% <0.00%> (-0.02%) ⬇️
packages/sycamore-core/src/view.rs 75.18% <100.00%> (-0.36%) ⬇️
packages/sycamore-macro/src/view/parse.rs 98.36% <100.00%> (ø)
packages/sycamore-reactive/src/effect.rs 99.31% <100.00%> (-0.01%) ⬇️
packages/sycamore-reactive/src/iter.rs 97.54% <100.00%> (-0.06%) ⬇️
packages/sycamore-reactive/src/lib.rs 94.22% <100.00%> (-0.15%) ⬇️
packages/sycamore-web/src/ssr_node.rs 75.13% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lukechu10 lukechu10 merged commit 75be1ca into master Aug 21, 2022
@lukechu10 lukechu10 deleted the remove-unsafes branch August 21, 2022 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING CHANGE Breaking changes introduced in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant