Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update endpoint to search by txHash adding chainId as optional parameter #115

Closed
wainola opened this issue Oct 4, 2023 · 1 comment · Fixed by #117
Closed

Update endpoint to search by txHash adding chainId as optional parameter #115

wainola opened this issue Oct 4, 2023 · 1 comment · Fixed by #117
Assignees

Comments

@wainola
Copy link
Contributor

wainola commented Oct 4, 2023

Since there is the chance -small one-, that txHash could not be unique, we should fetch transfer passing txHash + chainId

Implementation details

  • update current endpoint to receive chainId as optional parameter

Testing details

  • update test to reflect the change

Acceptance Criteria

  • tests are passing
  • we are able to fetch transfer by txHash + chainId
@mpetrun5
Copy link
Contributor

mpetrun5 commented Oct 4, 2023

The issue is not with the chainID (though I guess that might be a consideration as well but hash collision is very unlikely).
The issue is that someone can program a contract that creates multiple transfers in the same transaction hash.

@wainola wainola changed the title Update endpoint to search by txHash and chainId Update endpoint to search by txHash adding chainId as optional parameter Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants