Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove linked dependency from examples #130

Closed
wainola opened this issue Dec 1, 2022 · 1 comment · Fixed by #139
Closed

Remove linked dependency from examples #130

wainola opened this issue Dec 1, 2022 · 1 comment · Fixed by #139
Assignees

Comments

@wainola
Copy link
Contributor

wainola commented Dec 1, 2022

All of our current examples use sdk as linked dependency and not from npm registry. This add complexity when trying to run examples and its less straightfoward since it need to run TS compiler in the sdk folder.

Implementation details

Remove examples folder from workspaces to use dependency from npm.

Testing details

Acceptance Criteria

@BeroBurny
Copy link
Collaborator

Wound recommends doing that way explained in "Implementation details" as the project uses yarn workspaces and there is a feature that provides a perfect option for this case.
You can change link approach (that is pretty outdated) in favor of the workspace:^ example in filesnap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants