Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Check/update dependencies for packages #138

Merged
merged 2 commits into from
Jan 16, 2023
Merged

fix: Check/update dependencies for packages #138

merged 2 commits into from
Jan 16, 2023

Conversation

enemycnt
Copy link
Contributor

@enemycnt enemycnt commented Jan 9, 2023 •
edited

Description

Related Issue Or Context

Closes: #123

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in chainbridge-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@enemycnt enemycnt requested a review from wainola January 9, 2023 08:19
@enemycnt enemycnt changed the title Check/update dependencies for packages fix: Check/update dependencies for packages Jan 9, 2023
@wainola wainola requested a review from BeroBurny January 9, 2023 11:55
@BeroBurny
Copy link
Collaborator

Can be #130 included in this PR?

BeroBurny
BeroBurny previously requested changes Jan 9, 2023
View reviewed changes
Copy link
Collaborator

@BeroBurny BeroBurny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use yarn outdated to check available package updates.
Found a lot of packages that have patches and did not updated in this PR

@enemycnt
Copy link
Contributor Author

Can be #130 included in this PR?

I've created separate PR for that issue

@wainola
Copy link
Contributor

wainola commented Jan 13, 2023

Can we merge this?

@enemycnt enemycnt dismissed BeroBurny’s stale review January 16, 2023 13:28

We will update packages in future PRs.

@enemycnt enemycnt merged commit b4875e8 into main Jan 16, 2023
@enemycnt enemycnt deleted the fix/dependecies-fix branch January 16, 2023 13:28
@github-actions github-actions bot mentioned this pull request Jan 16, 2023
Merged
@BeroBurny BeroBurny mentioned this pull request Jan 16, 2023
Closed
@enemycnt enemycnt mentioned this pull request Mar 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wainola wainola wainola approved these changes

@BeroBurny BeroBurny BeroBurny left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check/update dependencies for packages
3 participants
@enemycnt @BeroBurny @wainola