Implement fungible EVM transfers #371
Comments
|
Hey team! Please add your planning poker estimate with Zenhub @Lykhoyda @mpetrunic @saadjhk @wainola |
4 tasks
saadjhk
added a commit
that referenced
this issue
Jun 14, 2024
<!--- Summarize the feature or epic briefly, including its scope or the problem it addresses. --> Following the [proposed `v3` SDK restructure](https://github.com/sygmaprotocol/sygma-sdk/tree/v3), implement/restructure the necessary functions for creating deposit EVM transactions for fungible assets (ERC20). ## Implementation details <!-- Detail the implementation approach, including technical design, architecture decisions, and dependencies. Link to design documents or diagrams if relevant. --> - Check `packages/evm/src/fungible.ts` for the interface definitions. - Make sure to also tackle bug #363 with this refactor ## Testing details <!-- Outline special test cases, edge cases, integration points. --> - Restructure and update existing unit tests (expand if required) - Validate manually that refactored `evm-to-evm-fungible-transfer-example` is passing on testnet ## QA Details <!-- Specify environments, configurations, or tools required for QA. Highlight potential problem areas or known issues to focus on during testing. --> - New exposed interfaces and functions should allow the same functionalities as the v2 SDK implementation, such as the creation of fungible EVM transfers and the estimation of fees. ## Acceptance Criteria - [x] Implementing fungible EVM transfers following `v3` guidlines - [x] Restructure and update existing unit tests - [x] Update `evm-to-evm-fungible-transfer-example` example to use `v3` implementation - [x] Validate `evm-to-evm-fungible-transfer-example` example manually on testnet Closes: #371 --------- Signed-off-by: Saad Ahmed <saad@chainsafe.io> Co-authored-by: mace <mak@chainsafe.io> Co-authored-by: anton <anton@chainsafe.io> Co-authored-by: Nicolás <nicolas@chainsafe.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Following the proposed
v3SDK restructure, implement/restructure the necessary functions for creating deposit EVM transactions for fungible assets (ERC20).Implementation details
packages/evm/src/fungible.tsfor the interface definitions.Testing details
evm-to-evm-fungible-transfer-exampleis passing on testnetQA Details
Acceptance Criteria
v3guidlinesevm-to-evm-fungible-transfer-exampleexample to usev3implementationevm-to-evm-fungible-transfer-exampleexample manually on testnetThe text was updated successfully, but these errors were encountered: