Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet account selector #74

Closed
mpetrunic opened this issue Feb 5, 2024 · 2 comments · Fixed by #106 or #186
Closed

Wallet account selector #74

mpetrunic opened this issue Feb 5, 2024 · 2 comments · Fixed by #106 or #186
Assignees

Comments

@mpetrunic
Copy link
Member

Implementation details

Substrate doesn't have the same concept around single connected account like in ethereum. We should display all accounts from connected wallet and allow user to select from which he wants to send transaction.

Testing details

Acceptance Criteria

@sweetpea22
Copy link

Screen Shot 2024-02-05 at 10 59 43 AM

hey.
left modal keeps the width of the widget fixed. right modal makes the widget container flexible to the width of the address string. i'm happy with whatever you choose.

i took a lot of inspiration from the hydraDX selector UI. tell me what is not relevant/out of scope, ok? :)

  • modal title shows the name of the connected wallet provider.

within the account option:

  • shows the network that the account belongs to (Substrate)
  • shows account name.
  • shows check if onchain identity is set
  • shows balance
  • shows copy icon

let me know what to change, thank you

@mpetrunic
Copy link
Member Author

For MVP I would not go into separate screens for selecting account. Lets keep it simple, just a dropdown with account name + address?

wainola pushed a commit that referenced this issue Mar 4, 2024
Lykhoyda added a commit that referenced this issue Apr 15, 2024
mpetrunic pushed a commit that referenced this issue May 7, 2024
MakMuftic added a commit that referenced this issue Jun 13, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>@buildwithsygma/sygmaprotocol-react-widget:
0.1.3</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @buildwithsygma/sygmaprotocol-widget bumped to 0.2.0
</details>

<details><summary>sygmaprotocol-widget: 0.2.0</summary>

##
[0.2.0](sygmaprotocol-widget-v0.1.2...sygmaprotocol-widget-v0.2.0)
(2024-06-13)


### Features

* automatically add unknown source evm network into wallet
([#162](#162))
([d5886bd](d5886bd))
* display amount to be received on destination
([#168](#168))
([347f7a5](347f7a5))
* Display Fee
([#145](#145))
([872703d](872703d))
* display transfer gas cost estimation
([#174](#174))
([b154555](b154555))
* enable developers to configure network whitelisting
([#170](#170))
([5db505f](5db505f))
* enable user to specify wallets
([#161](#161))
([8a02170](8a02170))
* Retry loading bridge routes
([#136](#136))
([8e0101f](8e0101f))
* substrate fungible transfer
([#134](#134))
([337f1b7](337f1b7))
* wallet account selector for substrate
([#106](#106))
([79127fd](79127fd)),
closes [#74](#74)


### Bug Fixes

* amount to receive
([#196](#196))
([8c2cdad](8c2cdad))
* destination address format
([#197](#197))
([250ea35](250ea35))
* explorer urls when adding networks
([#200](#200))
([d65d99a](d65d99a))
* Fixed amount to receive decimals
([#208](#208))
([be23500](be23500))
* Gas Fee estimation behavior, is not consistent for the actual transfer
TX ([#204](#204))
([d57233e](d57233e))
* handling transfer cancellation on substrate
([#195](#195))
([6ce25cb](6ce25cb))
* resource name
([#201](#201))
([1215dcc](1215dcc))
* resource selector
([#199](#199))
([81bae38](81bae38))
* small fix for tangle connection
([#212](#212))
([557d71e](557d71e))
* source switch reset
([#206](#206))
([1b1f92c](1b1f92c)),
closes [#205](#205)
* typesafety when handling changed properties
([#141](#141))
([692e269](692e269))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants