using new setting in prdisplay

syj67507 · May 28, 2024 · 4118a3c · 4118a3c
1 parent af2dceb
commit 4118a3c
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 11 deletions.
diff --git a/src/popup/components/PRDisplay/RepoSection/PullRequest/index.tsx b/src/popup/components/PRDisplay/RepoSection/PullRequest/index.tsx
@@ -24,11 +24,13 @@ interface PullRequestProps {
    * repo that this pull request is associated with
    */
   isJiraConfigured: boolean;
+  statusChecksSetting: boolean;
 }
 
 export default function PullRequest({
   pr,
   isJiraConfigured,
+  statusChecksSetting,
 }: PullRequestProps) {
   return (
     <Stack
@@ -49,17 +51,21 @@ export default function PullRequest({
           <Typography variant="caption" fontStyle="italic">
             {pr.username}
           </Typography>
-          <Box
-            onClick={() => {
-              createTab(pr.checksUrl).catch(() => {
-                console.error(`Failed to create tab with url ${pr.checksUrl}`);
-              });
-            }}
-          >
-            {pr.checksState === "SUCCESS" && <SuccessStatusChecksIcon />}
-            {pr.checksState === "FAILURE" && <FailedStatusChecksIcon />}
-            {pr.checksState === "PENDING" && <PendingStatusChecksIcon />}
-          </Box>
+          {statusChecksSetting && (
+            <Box
+              onClick={() => {
+                createTab(pr.checksUrl).catch(() => {
+                  console.error(
+                    `Failed to create tab with url ${pr.checksUrl}`
+                  );
+                });
+              }}
+            >
+              {pr.checksState === "SUCCESS" && <SuccessStatusChecksIcon />}
+              {pr.checksState === "FAILURE" && <FailedStatusChecksIcon />}
+              {pr.checksState === "PENDING" && <PendingStatusChecksIcon />}
+            </Box>
+          )}
         </Stack>
         <Typography
           variant="caption"

diff --git a/src/popup/components/PRDisplay/index.tsx b/src/popup/components/PRDisplay/index.tsx
@@ -12,6 +12,7 @@ import {
   useGetAnimatedExpandSetting,
   useGetHeaderClickBehavior,
   useGetPullRequests,
+  useGetStatusChecksSetting,
   useSavedFilters,
 } from "../../hooks";
 
@@ -20,6 +21,7 @@ export default function PRDisplay() {
   const { loading, data, username, token } = useGetPullRequests();
   const [headerClickBehavior] = useGetHeaderClickBehavior();
   const [animatedExpandSetting] = useGetAnimatedExpandSetting();
+  const [statusChecksSetting] = useGetStatusChecksSetting();
 
   return (
     <Stack width="100%" bgcolor="whitesmoke" padding={1} spacing={1}>
@@ -85,6 +87,7 @@ export default function PRDisplay() {
                         key={pr.url}
                         pr={pr}
                         isJiraConfigured={repo.isJiraConfigured}
+                        statusChecksSetting={statusChecksSetting}
                       />
                     ))
                   : filtered.length === 0 && <NoPullRequest url={repo.url} />}