Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Status checks for each pull request #59

Merged
merged 3 commits into from
May 19, 2024
Merged

Conversation

syj67507
Copy link
Owner

@syj67507 syj67507 commented May 19, 2024

Summary

In this PR, the status check reports have been added to be visible on each pull request.

There are a few things to note:

  • The checks may not be completely accurate if the repository is configured with external 3rd party tools for adding checks on a pull request
  • The checks icon will show the overall status of success, failed, pending, or if there aren't any configured
  • At the moment the performance has taken a hit because the query for the API has become more complicated, this will be addressed before this feature is available for users

Changes

  • Updated query to fetch status checks information
  • Parallelized the query to split up the complexity of the query over multiple calls
  • Added new components to render icons next to the author on the pull request and clicking on them will navigate to the checks for the pull request

Screenshots / GIFs

Details

image

Other changes

  • Updated the icons for if the user has previously reviewed

Other Notes

  • This feature will probably be off by default and can be enabled in the settings page with a description that explains that these checks may not be completely accurate for the reasons mentioned above in the summary
  • Performance will need to be enhanced to make this extension load more quickly, likely by making it fetch the pull requests for a given repository only when opening a repo section

@syj67507 syj67507 merged commit 3e28f96 into main May 19, 2024
2 checks passed
@syj67507 syj67507 deleted the feature/status-checks branch May 19, 2024 18:15
syj67507 added a commit that referenced this pull request May 28, 2024
### Summary

In this PR, a new setting has been introduced for the status check
feature. By default this setting will be turned off and there is a short
description that it may not be completely accurate. More details on why
it is labeled as an "experimental" feature is described in #59

### Changes
- Added a new hook along with extension methods to save and fetch the
configured setting from storage
- Hook is used in the <PRDisplay /> component and passed to each of the
<PullRequest /> components
- Updates in <PullRequest />  components to make use of the new setting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant