Bundle OSS licenses #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
|
Wouldn't it be better if the licenses would get generated by CI, and we would not have to do it manually? |
|
Either way, we have to include license files in this repository. It makes it clear - if we update dependencies, we also have to update licenses not only in the app, but also in repository.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds OSS licenses into iOS Settings app. With this, LunchGuy finally comply to licenses included in its dependencies and fixes #4.
The license plist files are autogenerated using LicensePlist tool which needs to be installed using homebrew explicitly. The Xcode project now also includes aggregated target which runs
LicensePlistin background. If the tool is not installed, the target build fails.I also included action for Danger, which warns whenever the
Podfilewas updated, but the license plists remained unmodified.