Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition to git layer: blamer #15122

Closed
phenix-factory opened this issue Oct 25, 2021 · 4 comments
Closed

Addition to git layer: blamer #15122

phenix-factory opened this issue Oct 25, 2021 · 4 comments
Assignees
Labels
Feature request stale marked as a stale issue/pr (usually by a bot)

Comments

@phenix-factory
Copy link

Hello,

I just found this package on HN and I think it would be nice to have it in the git layer.

https://github.com/Artawower/blamer.el

@BenedictHW
Copy link
Contributor

Thanks for linking the HN discussion, good stuff. The comments mention
this functionality is already available in magit-blame, though not very well
advertised.

  1. M-x RET magit-blame RET m (or b) inside a source code buffer to activate
    the magit blame minor mode and then move the pointer around. There should be
    blame context in the minibuffer.
  2. M-x RET magit-blame-cycle-style when in magit-blame mode. This is
    awesome. Might just replace SPC g f l (magit-log-buffer-file) and C-x v g (vc-annotate) for me.

https://magit.vc/manual/magit/Blaming.html

@phenix-factory
Copy link
Author

Thanks for linking the HN discussion, good stuff.

Irony I guess. You right anyway: Thanks for linking the HN discussion, good stuff.

The comments mention this functionality is already available in magit-blame, though not very well
advertised.

This is not really the same functionality. I know about magit-blame. Blamer does it differently since the blame is always on and on every line you move your cursor on.

@smile13241324
Copy link
Collaborator

We can add blamer to the git layer and have users make a choice between blamer and magit blame via a config var. In both cases we should have clear bindings for this feature.

@github-actions github-actions bot added the stale marked as a stale issue/pr (usually by a bot) label Nov 28, 2022
Repository owner deleted a comment from github-actions bot Feb 26, 2023
@lebensterben lebensterben removed Help wanted stale marked as a stale issue/pr (usually by a bot) labels Feb 26, 2023
@lebensterben lebensterben self-assigned this Feb 26, 2023
@lebensterben lebensterben reopened this Feb 26, 2023
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please let us know if this issue is still valid!

@github-actions github-actions bot added the stale marked as a stale issue/pr (usually by a bot) label Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request stale marked as a stale issue/pr (usually by a bot)
Projects
None yet
Development

No branches or pull requests

4 participants