Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation of dotspacemacs-swap-number-row #16419

Merged

Conversation

fnussbaum
Copy link
Contributor

Fixes #16417

Copy link
Collaborator

@smile13241324 smile13241324 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the comments in the dot file template also need to be changed.

@fnussbaum
Copy link
Contributor Author

fnussbaum commented May 30, 2024

The comment in the template seems to be up to date in the sense that it includes querty-ca-fr already:

   ;; If non-nil shift your number row to match the entered keyboard layout
   ;; (only in insert state). Currently supported keyboard layouts are:
   ;; `qwerty-us', `qwertz-de' and `querty-ca-fr'.
   ;; New layouts can be added in `spacemacs-editing' layer.
   ;; (default nil)
   dotspacemacs-swap-number-row nil

@smile13241324 Is there something else that needs to be changed?

@smile13241324
Copy link
Collaborator

Nope that's fine then

@smile13241324 smile13241324 merged commit f6517ab into syl20bnr:develop May 31, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot enable dotspacemacs-swap-number-row.
2 participants