Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eyebrowse integration enhancement (go to buffer vs. bring buffer) #4075

Closed
syl20bnr opened this issue Dec 6, 2015 · 7 comments
Closed

Eyebrowse integration enhancement (go to buffer vs. bring buffer) #4075

syl20bnr opened this issue Dec 6, 2015 · 7 comments
Labels
- Mailling list - Spacemacs Layouts stale marked as a stale issue/pr (usually by a bot)

Comments

@syl20bnr
Copy link
Owner

syl20bnr commented Dec 6, 2015

Now we have multiple workspaces support per perspective thanks to @bmag we need to support these two commands:

  1. (go to buffer) switch to buffer in perspective and automatically switch to the workspace where the buffer is visible (in case of multiple workspaces switch to the first one)
  2. (bring buffer) "bring" the buffer to the current workspace

2. is a fallback to 1. if the latter returns nil.

I propose that "go to buffer" is the default action bound to SPC l b and "bring buffer" is a secondary action which could be bound to SPC l B (we may have to find another binding for imenu-buffer under SPC b B).

@joehillen
Copy link
Contributor

Sounds good to me. 👍

Should the behaviour of SPC b b change? Maybe change it to the current behaviour of SPC l b?

@syl20bnr
Copy link
Owner Author

syl20bnr commented Dec 6, 2015

I'm not for changing the behavior of SPC b b which display all the opened buffers no matter the current context:

  • SPC b b is global scope
  • SPC p b is project scope
  • SPC l b is layout scope

I'm more in favor of changing the behavior of SPC b b to match SPC l b "go to buffer" (in this case, it would change the perspective and workspace) and SPC b B would import a buffer into current perspective/workspace.

@bmag
Copy link
Collaborator

bmag commented Dec 6, 2015

Sounds good to me too. I think it will be quite helpful.
Please note there is no built-in functionality to search for a buffer in a workspace, but it's possible to write one. It requires analyzing a window-state-get object, though. Anyone heard of a library that analyzes window-state-get objects?
Also, obvious alternative mnemonic for ibuffer is SPC b i. Is the new SPC b B supposed to be the same as SPC l a, or will there be differences?

@bmag
Copy link
Collaborator

bmag commented Feb 10, 2016

I wrote some code that makes it easy to implement a go-to-buffer function. Most of the code analyses window-state objects, so I'm considering publishing it as (a part of) an ELPA package, so it would take at least several more days until I upload it somewhere.
switch-to-buffer already acts as the described bring-buffer, so we can just use it as is.

@syl20bnr do we still want to implement this? If so, where should we put the go-to-buffer and bring-buffer commands? There were changes to the UX (as you know) since two months ago, and I'm not sure where to put the commands.

@bmag
Copy link
Collaborator

bmag commented Feb 23, 2016

I have implemented a spacemacs/goto-buffer-workspace command in #5201. It addresses the part of the suggestion above. It's not clear to me how to continue from here, so I'm leaving it as is.

@TheBB
Copy link
Collaborator

TheBB commented Feb 25, 2016

#5201 is merged.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please let us know if this issue is still valid!

@github-actions github-actions bot added the stale marked as a stale issue/pr (usually by a bot) label Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- Mailling list - Spacemacs Layouts stale marked as a stale issue/pr (usually by a bot)
Projects
None yet
Development

No branches or pull requests

5 participants