Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parinfer layer #5574

Closed
gilch opened this issue Mar 23, 2016 · 17 comments
Closed

Parinfer layer #5574

gilch opened this issue Mar 23, 2016 · 17 comments

Comments

@gilch
Copy link
Contributor

@gilch gilch commented Mar 23, 2016

Consider adding a parinfer layer.

Parinfer is like a more powerful adjust-parens, and also includes a slightly less aggressive version of aggressive-indent-mode as a separate mode.

Lisp users prefer to read their code by indentation rather than by counting delimiters. Parinfer makes editing Lisp feel more like editing Python. Parinfer gives you most of the power of paredit (and evil-cleverparens for that matter), but is much easier to learn as evidenced by its inclusion in Nightcode.

There is already a parinfer package for emacs. It may need a little work. The inference engine used by other editors seems to work correctly, and the package includes a direct translation of it into emacs lisp. But the emacs integration doesn't work as well as the other editors I've tried. Sometimes the point doesn't end up where I expect. It may need some adjustments to play nice with evil. LightTable has independent plugins for both Vim keys and Parinfer that work well together, so I don't expect this to be a problem for long. These are minor issues the spacemacs community could fix quickly once a layer is available for testing.

@a13ph
Copy link

@a13ph a13ph commented Jul 27, 2016

Those points might also be of use to those interesting on hacking or using parinfer:
https://github.com/noctuid/parinfer-notes (assuming they are still relevant)

@gilch
Copy link
Contributor Author

@gilch gilch commented Jul 27, 2016

They're not. Ignore the above article. It's unfairly biased and factually incorrect. I could rebut it point-by-point (and will, if necessary) but I don't want to encourage anyone else to read it.

@dilzeem
Copy link

@dilzeem dilzeem commented Aug 7, 2016

@gilch Have you been able to hack something together on spacemacs?

@gilch
Copy link
Contributor Author

@gilch gilch commented Aug 8, 2016

There's a more recent port of Parinfer to elisp now: https://github.com/oakmac/parinfer-elisp

It's just the inference engine, but it has an extensive test suite. The question is when exactly to invoke these functions (and when not to) to make it cooperate with Spacemac's other packages, especially Evil.

@JAremko
Copy link
Collaborator

@JAremko JAremko commented Sep 20, 2016

42 👍 Spacemacs needs its hero :shipit:

@JAremko
Copy link
Collaborator

@JAremko JAremko commented Sep 20, 2016

https://www.youtube.com/watch?v=mqjDOSKyIcc

They're beating us! Unacceptable 👿

@zhxchen17
Copy link

@zhxchen17 zhxchen17 commented Sep 30, 2016

Just wanna mention there is another promising port for parinfer at https://github.com/DogLooksGood/parinfer-mode

@DogLooksGood
Copy link

@DogLooksGood DogLooksGood commented Oct 10, 2016

I've add a PR for parinfer layer, #7339.

@achikin
Copy link

@achikin achikin commented May 29, 2017

Is it going to be merged at some point?

@JAremko
Copy link
Collaborator

@JAremko JAremko commented May 29, 2017

@achikin no!

Guess why 😉

@achikin
Copy link

@achikin achikin commented May 29, 2017

@JAremko :))) Sorry.

@PrestanceDesign
Copy link

@PrestanceDesign PrestanceDesign commented Jan 12, 2019

Is it going to be merged at some point?

@JAremko No, why ?

@JAremko
Copy link
Collaborator

@JAremko JAremko commented Jan 12, 2019

@pablooliveira Because it was already merged 🙄

@PrestanceDesign
Copy link

@PrestanceDesign PrestanceDesign commented Jan 13, 2019

@JAremko Haha nice, thanks. :)
Why this issue is still open ? WIP ?

@JAremko
Copy link
Collaborator

@JAremko JAremko commented Jan 13, 2019

@PrestanceDesign It's tagged with "fixed in develop" it means that the issue will be closed with the next release (when the commit end up in the master branch)

We got really inconsistent with this lately. 🤔

@JAremko
Copy link
Collaborator

@JAremko JAremko commented Jan 13, 2019

Solved in #7339

@JAremko JAremko closed this Jan 13, 2019
@PrestanceDesign
Copy link

@PrestanceDesign PrestanceDesign commented Jan 13, 2019

Thx you very much @JAremko. (y)
I did not pick up the tag, I'll pay attention now ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Mailing list
New packages or layers
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
You can’t perform that action at this time.