Magit "y" binding (magit-show-refs) is provided in magit "?" popup, but unusable

[mikavilpas]

Hi guys, thanks for your work on spacemacs - I love it.

Here's how to reproduce this minor issue I found:

• open magit via SPC g s
• press ? to bring up magit-dispatch-popup
• the popup lists pressing y as "Show refs"
• press y -> magit-refs is shown normally

But if you try to press y without first pressing ?, it acts like evil's y (yank).
Btw, my spacemacs-version is "0.105.16".

[joehillen]

Paging @justbur

[justbur]

This is intended. See https://github.com/justbur/evil-magit#key-bindings.

You can set evil-magit-use-y-for-yank to nil before loading evil-magit if you want y to only show-refs.

[mikavilpas]

I see, thanks for letting me know!

[joehillen]

@justbur is it possible to change what the popup says based on how evil-magit-use-y-for-yank is set?

[justbur]

@joehillen It doesn't really make sense. It would have to be yr for show-refs, but that would mean creating a new popup under y with one entry for r. That would also break the functionality of yy, ys and yb. Magit popups are not that flexible.

If you don't like the yank stuff you can disable it. I personally think the slight inconsistency in the popup versus no popup behavior is worth the added functionality.

[joehillen]

It's not possible it have the popup show "yr Show Refs" instead of "y Show Refs"?

I personally don't mind yank behaviour. I'm just curious if the popup could be made more clear to avoid future confusion.

[justbur]

It's not possible it have the popup show "yr Show Refs" instead of "y Show Refs"?

As far as I know, no. Actions are bound to single characters. If there's an easy way to do it I'm not aware of it.

Which-key pops up after y and shows the options though.

[joehillen]

I see.

I think a better solution than yr might be to change the binding to something unused (there aren't a whole lot of options left though).

J seems like it could work.

[justbur]

I think a better solution than yr might be to change the binding to something unused (there aren't a whole lot of options left though).

No there aren't. I'm open to other possibilities. Hopefully something that helps you remember it

[tarsius]

"Sub-popups" are now possible, here's an example. Whether creating a new popup for this is worth it, I don't know.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please let us know if this issue is still valid!