Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-mode doesn't have syntax highlighting for jsdoc #5950

Closed
sdn90 opened this issue May 1, 2016 · 3 comments
Closed

react-mode doesn't have syntax highlighting for jsdoc #5950

sdn90 opened this issue May 1, 2016 · 3 comments

Comments

@sdn90
Copy link

sdn90 commented May 1, 2016

System Info

  • OS: darwin
  • Emacs: 24.5.1
  • Spacemacs: 0.105.19
  • Spacemacs branch: master (rev. 5f26b82)
  • Graphic display: t
  • Distribution: spacemacs
  • Editing style: vim
  • Completion: helm
  • Layers:
(shell :variables shell-default-shell 'multiterm shell-default-term-shell "/bin/zsh")

Works when switching to js2-mode

screen shot 2016-04-30 at 5 02 10 pm

@axyz
Copy link
Contributor

axyz commented May 2, 2016

jsdoc syntax highlight is a js2 feature not included on js2-minor-mode used by react layer.

Also on develop we are trying to remove js2-minor from react-layer so it is probably a feature that needs anyway to be extracted from js2 and ported elsewhere.

One solution may be to include it directly on react layer, but wouldn't be a very good idea as it is a really distinct feature and should live on its own module. Probably the best idea would be to implement it on the js-doc package that is already used in develop by the react-layer.

I will fill an issue on https://github.com/mooz/js-doc to ask if it may be a viable solution.

@TheBB
Copy link
Collaborator

TheBB commented May 5, 2016

mooz/js-doc#10

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please let us know if this issue is still valid!

@github-actions github-actions bot added the stale marked as a stale issue/pr (usually by a bot) label Feb 29, 2020
@lebensterben lebensterben removed the stale marked as a stale issue/pr (usually by a bot) label Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Upstream bugs
Reported, waiting
Forum
  
To close
Development

No branches or pull requests

5 participants