New undo behaviour

[samdesota]

Edit:

Description

Is there new undo behavior? If so, how can I change it?
The grouping appears to be messed up.

Reproduction guide 🪲

• Start Emacs
• Insert text on one line
• move to another line
• delete the line
• hit undo

Observed behaviour: 👀
it put's the line back, but then goes back to the line you inserted text on and removes the insert

Expected behaviour: 💔
It put's the line back

System Info 💻

• OS: darwin
• Emacs: 25.0.94.1
• Spacemacs: 0.105.20
• Spacemacs branch: develop (rev. 9414a8a)
• Graphic display: t
• Distribution: spacemacs
• Editing style: vim
• Completion: helm
• Layers:

(auto-completion search-engine fasd emacs-lisp react html git markdown org clojure yaml haskell elm rust
                 (shell :variables shell-default-shell 'eshell shell-default-height 30 shell-default-position 'bottom)
                 spell-checking syntax-checking version-control)

[syl20bnr]

Interesting, I'll check it out, we did not change anything in this regard.
In the meantime be sure that your packages are up to date.

[syl20bnr]

Also use SPC h I to submit your issue, this way we can have more info about your system.

[samdesota]

Updated with SPC h I

[samdesota]

I'm on the latest develop, also.

[Stebalien]

Could you give the reproduction instructions assuming one starts in a scratch buffer and give the exact key sequence? For example, ia<RET>b<RET>c<ESC>ggAa<ESC>jddu (which doesn't reproduce the problem for me).

-- edit: ggAa, not ggaa

[samdesota]

Your moves appeared broken, this appears not to work also:

ifoo<RET>bar<ESC>kA test<ESC>jddu

I'm going to try and move my .spacemacs to .back and then try again.

[samdesota]

Still broken on a fresh .spacemacs

[samdesota]

Cloned master, fresh .spacemacs, still broken. Could be a problem with GNU Emacs 25?

[Stebalien]

Still can't reproduce but I'm using emacs 24.5. Have you tried setting evil-want-fine-undo to nil (wild guess)?

[StreakyCobra]

You can also try to look for similar problems upstream here.

A potentially related one: https://bitbucket.org/lyro/evil/issues/594/undo-doesnt-behave-like-vim

[samdesota]

Looks like it's an issue with Emacs 25. Setting evil-in-single-undo to t fixed it though.

Thanks!

[syl20bnr]

So we can consider to add that setting in Spacemacs.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please let us know if this issue is still valid!