Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ivy layouts buffer switching doesn't respect layout #6300

Closed
darkfeline opened this issue Jun 11, 2016 · 4 comments
Closed

ivy layouts buffer switching doesn't respect layout #6300

darkfeline opened this issue Jun 11, 2016 · 4 comments

Comments

@darkfeline
Copy link
Contributor

SPC l b (switch to buffer respecting layouts) doesn't work with ivy.

The relevant function in the ivy layer:

(defun spacemacs/ivy-spacemacs-layout-buffer ()
  "Switch to layout buffer using ivy."
  (interactive)
  (let (ivy-use-virtual-buffers)
    (with-persp-buffer-list ()
                            (call-interactively 'ivy-switch-buffer))))

However, ivy-switch-buffer doesn't use buffer-list internally, so with-persp-buffer-list here doesn't do anything.

@darkfeline darkfeline changed the title SPC l b with ivy doesn't work ivy layouts buffer switching doesn't respect layout Jun 11, 2016
@d12frosted
Copy link
Collaborator

Hm... indeed. But I think previously it worked. I mean, I remember SPC l b helping me a lot compared to SPC b b.

@ahyatt
Copy link
Contributor

ahyatt commented Sep 30, 2016

FWIW, there is a gist with code to fix this linked from persp-mode: https://gist.github.com/Bad-ptr/1aca1ec54c3bdb2ee80996eb2b68ad2d#file-persp-ivy-el

@bmag
Copy link
Collaborator

bmag commented Sep 30, 2016

@ahyatt thanks, that looks promising.

@TheBB
Copy link
Collaborator

TheBB commented Oct 20, 2016

Should be fixed in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants