Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

have to Ctrl-x in terminal to close Emacs in Cygwin #6339

Closed
xarthurx opened this issue Jun 15, 2016 · 3 comments
Closed

have to Ctrl-x in terminal to close Emacs in Cygwin #6339

xarthurx opened this issue Jun 15, 2016 · 3 comments
Labels
- Bug tracker - New OS stale marked as a stale issue/pr (usually by a bot)

Comments

@xarthurx
Copy link

#### Description

When exit Emacs normally using Ctrl-x Ctrl-c, Emacs will freeze.
Then I need to press Ctrl-x (kill process) in Cygwin terminal to let Emacs continue the closing process...
Then Emacs will close normally.

When using my personal .emacs.d, everything works fine.

Reproduction guide

  • Start Emacs
  • Press Ctrl-x
  • Press Ctrl-c

Observed behaviour:
DESCRIPTION OF THE OBSERVED BEHAVIOUR

Expected behaviour:
Ctrl-x Ctrl-c will close Emacs normally.

System Info

  • OS: cygwin
  • Emacs: 24.5.1
  • Spacemacs: 0.105.21
  • Spacemacs branch: master (rev. 0283f64)
  • Graphic display: t
  • Distribution: spacemacs
  • Editing style: emacs
  • Completion: helm
  • Layers:
(emacs-lisp)

Backtrace

BACKTRACE IF RELEVANT
@corngood
Copy link
Contributor

corngood commented Sep 4, 2016

I've noticed this too. It's probably a bug in emacs or cygwin related to child processes, but I haven't actually reproduced it (yet) without spacemacs.

Usually when I start a spacemacs instance I get two child process (list-processes): aspell and server. When emacs is quitting it hangs with aspell still running. If I kill the aspell process, emacs exits.

If I disable spell checking, I have only the server process, but it still hangs on exit.

If I comment out the (server-start) in init.el, I no longer get the hang. If I manually run (server-start) the hang comes back.

However, if I start vanilla emacs with emacs -q and run (server-start), there's no hang on exit.

That's all I've got so far, but I'll keep investigating.

@corngood
Copy link
Contributor

corngood commented Sep 5, 2016

Ah, ok, I tracked it down to:

(defadvice kill-emacs (around spacemacs-really-exit activate)
  "Only kill emacs if a prefix is set"
  (if (and (not spacemacs-really-kill-emacs)
           (spacemacs/persistent-server-running-p))
      (spacemacs/frame-killer)
    ad-do-it))

So I suppose this just doesn't work as intended with the windows GUI emacs?

I mean, it works, but the window does close.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please let us know if this issue is still valid!

@github-actions github-actions bot added the stale marked as a stale issue/pr (usually by a bot) label Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- Bug tracker - New OS stale marked as a stale issue/pr (usually by a bot)
Projects
None yet
Development

No branches or pull requests

3 participants