Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javascript Layer: Support eslint auto fixing #6546

Closed
samdesota opened this issue Jul 10, 2016 · 6 comments
Closed

Javascript Layer: Support eslint auto fixing #6546

samdesota opened this issue Jul 10, 2016 · 6 comments
Labels
- Mailling list - Feature request JavaScript stale marked as a stale issue/pr (usually by a bot)

Comments

@samdesota
Copy link

Maintaining a .eslintrc and .jsbeautify obviously isn't ideal, and since eslint has fixing it would be wonderful to have that supported alongside js beautify.

I already have it working via this gist I threw together

The node script is needed since eslint's cli only supports fixing the actual files, not buffers/text.

I understand eslint is flycheck's thing, but I don't think flycheck will be supporting this anytime soon. Let me know if you think this is possible, thanks!

@oiwn
Copy link

oiwn commented Jul 20, 2016

How it's going? I think this is what i need to reach the nirvana. Normal support of modern es6/jsx

@samdesota
Copy link
Author

@istinspring You can set it up yourself by adding the node script to your $PATH and copying the .spacemacs code to your user config, then fix with SPC e e f.

@syl20bnr Do you know how this would be implemented in the javascript layer and if you would accept a pull request?

@CarlQLange
Copy link
Contributor

This would be amazing :)

@haishengwu-okta
Copy link
Contributor

hi @mrapogee , what is SPC e e f? I didn't find at https://github.com/syl20bnr/spacemacs/tree/master/layers/%2Bcheckers/syntax-checking#key-bindings

@samdesota
Copy link
Author

https://gist.github.com/mrapogee/ae0674c6ba33025b1bd13e7d6561f76a

^-- I implemented it here. Haven't updated in a while so not sure if it's latest

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please let us know if this issue is still valid!

@github-actions github-actions bot added the stale marked as a stale issue/pr (usually by a bot) label Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- Mailling list - Feature request JavaScript stale marked as a stale issue/pr (usually by a bot)
Projects
Mailing list
  
Other
Development

No branches or pull requests

5 participants