Spacemacs losing key binding for discard region in magit with Vim/Hybrid mode

[tuhdo]

One useful feature of Magit is that you can mark a region in your hunk and discard it. The current key bindings prevent me from doing so, because it is assigned to other magit commands.

[TheBB]

Which editing style? (If only you had used SPC h I...)

[nixmaniack]

In hybrid I use x for discarding the marked region and I think it should be same for vim as we use evil-magit by default.

[nixmaniack]

Bindings for evil-magit were discussed and finalized at emacs-evil/evil-magit#2 (comment)

[tuhdo]

But I could not move forward/backward using j and k or w and b to mark a region.

[nixmaniack]

j and k are rightly bound to up/down movement for me which I think is the evil-magit default. But for horizontal movement, you need to set evil-magit-want-horizontal-movement to t which enables h/l for horizontal movement.

If j/k are not working for down/up movement(which should btw), then it might be the case spacemacs is doing something and I would suspect hybrid-mode-enable-hjkl-bindings from my spacemacs config for hybrid style.

Since selection in magit is only linewise there wasn't any need of having horizontal movement functionality but with evil-magit-want-horizontal-movement you can get minimal characterwise horizontal movement.

[TheBB]

I think we have answered everything here. Can this be closed @tuhdo?

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please let us know if this issue is still valid!