Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

command-key ";" in vim mode #7255

Closed
honza opened this issue Oct 3, 2016 · 8 comments
Closed

command-key ";" in vim mode #7255

honza opened this issue Oct 3, 2016 · 8 comments

Comments

@honza
Copy link

honza commented Oct 3, 2016

Description :octocat:

When using the vim mode of Spacemacs, setting dotspacemacs-command-key or
dotspacemacs-emacs-command-key seems to have no effect. Before the 0.200
release, I was able to set the command-key to ;, meaning I could avoid
having to hit shift+; to enter the vim command line menu.

The vim-related code that made this work was removed in 58e5241.

Reproduction guide 🪲

  • Start Emacs
  • Set dotspacemacs-command-key to ;
  • Reload emacs config with SPC f e R

Observed behaviour: 👀 💔

  • Hitting ; in normal mode doesn't enter command menu

Expected behaviour: ❤️ 😄

  • Hitting ; in normal mode does enter command menu

System Info 💻

  • OS: gnu/linux
  • Emacs: 25.1.1
  • Spacemacs: 0.200.0
  • Spacemacs branch: master (rev. e6357a5)
  • Graphic display: t
  • Distribution: spacemacs
  • Editing style: vim
  • Completion: helm
  • Layers:
(auto-completion better-defaults emacs-lisp c-c++ git github haskell shell-scripts purescript puppet ansible markdown notmuch org python clojure javascript html react go rust sql extra-langs syntax-checking version-control yaml
                 (spell-checking :variables spell-checking-enable-by-default nil))

Backtrace 🐾

none
@deb0ch
Copy link
Contributor

deb0ch commented Oct 4, 2016

Also experience that bug

@syl20bnr
Copy link
Owner

Fixed in 0.200.1 :-)

@honza
Copy link
Author

honza commented Oct 10, 2016

Thank you!

@lijoantony
Copy link

I'm still facing this bug on 0.200.4@24.5.1 (spacemacs)

@honza
Copy link
Author

honza commented Nov 1, 2016

@lijoantony Did you rename the config key name in your ~/.spacemacs file?

@lijoantony
Copy link

@honza I have the below line in my ~/.spacemacs inside dotspacemacs/init function.

dotspacemacs-command-key ";"

@honza
Copy link
Author

honza commented Nov 2, 2016

@lijoantony That's your problem. It should be (dotspacemacs-ex-command-key ";").

@lijoantony
Copy link

@honza Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants