Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript layers breaks web-mode usage on buffers without file #7314

Closed
Peluko opened this issue Oct 7, 2016 · 3 comments
Closed

Typescript layers breaks web-mode usage on buffers without file #7314

Peluko opened this issue Oct 7, 2016 · 3 comments
Labels
- Bug tracker - Web

Comments

@Peluko
Copy link

Peluko commented Oct 7, 2016

Typescript layer sets a hook on web-mode used to detect if file is tsx. This check uses buffer-file-name to obtain the file extension, but when the buffer is not attached to a file buffer-file-name is nil, so the check crashes.
@Peluko
Copy link
Author

Peluko commented Oct 7, 2016

PS: I use string-edit.el to edit templates contained into typescript strings. This mode creates a buffer without file for template editing, and this bug breaks web-mode usage in these buffers.

@TheBB
Copy link
Collaborator

TheBB commented Oct 7, 2016

Thanks, fixed.

@gilbertw1 gilbertw1 mentioned this issue Oct 14, 2016
Closed
@TheBB
Copy link
Collaborator

TheBB commented Oct 20, 2016

Should be fixed in master.

@TheBB TheBB closed this as completed Oct 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
- Bug tracker - Web
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Peluko @TheBB