Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

The suggestions provided by which-key do not describe what the key does #7882

Closed
esjee opened this issue Nov 30, 2016 · 6 comments
Closed

The suggestions provided by which-key do not describe what the key does #7882

esjee opened this issue Nov 30, 2016 · 6 comments

Comments

@esjee
Copy link

esjee commented Nov 30, 2016

Description :octocat:

The entries provided by which-key seem to be wrong. It appears that something like a namespace is rendered rather than a helpful function name.

Reproduction guide 馃

  • Start Emacs
  • Open any Ruby file
  • Press SPC r r

(The same issues seems to apply to all which-key suggestions, I just happened to choose SPC r r.)

Observed behaviour: 馃憖 馃挃
The suggestions provided by which-key are all the same: ruby/RuboCop.

2016-11-30-130900_854x60_scrot

Expected behaviour: 鉂わ笍 馃槃
The suggestions provided by which-key give an accurate description of what is going to happen, e.g. rubocop-check-current-file, rubocop-check-project, etc.

pasted image at 2016_11_30 11_54 am

System Info 馃捇

  • OS: gnu/linux
  • Emacs: 25.1.1
  • Spacemacs: 0.200.5
  • Spacemacs branch: master (rev. 664ba6a)
  • Graphic display: t
  • Distribution: spacemacs
  • Editing style: vim
  • Completion: helm
  • Layers:
(javascript
 (ruby :variables ruby-version-manager 'rvm ruby-test-runner 'rspec)
 ruby-on-rails helm auto-completion emacs-lisp git)
  • System configuration features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS NOTIFY LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11
@hiemanshu
Copy link

After doing some debugging on Gitter, found out that this is caused by a new which-key update. Rolling back to an older slot will fix this.

@esjee
Copy link
Author

esjee commented Nov 30, 2016

That indeed solved the issue! Thanks!

Is it helpful to leave this issue open, or do you prefer I close it out? I'm not sure if something in spacemacs needs to be changed, or if perhaps the latest which-key contains a bug.

@hiemanshu
Copy link

I think we should leave the issue open. Its a workaround to downgrade and not an actual fix.

@dubnde
Copy link
Contributor

dubnde commented Nov 30, 2016

May be justbur/emacs-which-key#155

Seems it has been fixed upstream and waiting for melpa to rebuild

@dubnde
Copy link
Contributor

dubnde commented Nov 30, 2016

Fixed which-key seems to be available on melpa now

@esjee
Copy link
Author

esjee commented Dec 2, 2016

Thanks! I just updated and it did indeed work as expected. The issue appears to have been resolved.

@esjee esjee closed this as completed Dec 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants