which-key upgrade broke replacement in descriptions

[slackorama]

Description

which-key descriptions are not replaced

Reproduction guide 🪲

• Start Emacs
• Type SPC s

Observed behaviour: 👀 💔
Descriptions are prefixed with "spacemacs/"

Expected behaviour: ❤️ 😄
Should not see descriptions prefixed with "spacemacs/"

I think this problem popped up with an upgrade to which-key. The which-key-description-alist was made obsolete on 11-21-2016. The new way of doing it is which-key-replacment-alist along with a new format. See here for all the details:
https://github.com/justbur/emacs-which-key#custom-string-replacement-options

Looks like this has to change:
https://github.com/syl20bnr/spacemacs/blob/master/layers/ distributions/spacemacs-bootstrap/packages.el#L279-L308

System Info 💻

• OS: gnu/linux
• Emacs: 25.1.1
• Spacemacs: 0.200.5
• Spacemacs branch: master (rev. 664ba6a)
• Graphic display: t
• Distribution: spacemacs
• Editing style: emacs
• Completion: helm
• Layers:

((auto-completion :variables auto-completion-enable-snippets-in-popup t)
 emacs-lisp
 (elfeed :variables elfeed-search-filter "-junk @1-week-ago  unread" elfeed-use-curl t rmh-elfeed-org-files
         (list
          (concat ssm-configs-dir "elfeed.org"))
         elfeed-db-directory
         (concat ssm-configs-dir "elfeed/")
         elfeed-goodies/entry-pane-position 'bottom)
 (git :git-enable-github-support t)
 github markdown
 (org :variables org-enable-reveal-js-support t org-enable-bootstrap-support t)
 python shell-scripts salt smason-lt restclient salt
 (shell :variables shell-default-height 30 shell-default-position 'bottom)
 spell-checking syntax-checking version-control
 (mu4e :variables mu4e-installation-path
       (expand-file-name "~/projects/mu/mu4e")
       :post-config)
 es-mode)

• System configuration features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS NOTIFY LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11

[slackorama]

whoops sorry, didn't realize it was fixed in develop already.