Improves jump-to-definition for Clojure modes #9792
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
related: #8663 |
|
I've been using this for a week, and it's been a nice improvement over the default behavior. I think it'd make a nice improvement to SM. |
|
Thank you ! 💜 |
agzam
added a commit
to agzam/.spacemacs.d
that referenced
this pull request
Dec 22, 2017
This syl20bnr/spacemacs#9792 has been merged
agzam
added a commit
to agzam/.spacemacs.d
that referenced
this pull request
Jan 21, 2018
This syl20bnr/spacemacs#9792 has been merged
practicalli-johnny
added a commit
to practicalli-johnny/spacemacs-fork
that referenced
this pull request
Jul 12, 2019
Update the existing `SPC m g g` keybinding to use the command `spacemacs/clj-find-var`. This makes finding a function definition a much better experience as you dont have to have the REPL running to find a definition, but when it is you can use a CIDER specific function. `spacemacs/clj-find-var` is a wrapper that calls `cider-find-var` if the REPL is running, otherwise it uses `dump-jump-go`. Wrapper added in syl20bnr#9792
practicalli-johnny
added a commit
to practicalli-johnny/spacemacs-fork
that referenced
this pull request
Jul 13, 2019
Update the existing `SPC m g g` keybinding to use the command `spacemacs/clj-find-var`. This makes finding a function definition a much better experience as you dont have to have the REPL running to find a definition, but when it is you can use a CIDER specific function. `spacemacs/clj-find-var` is a wrapper that calls `cider-find-var` if the REPL is running, otherwise it uses `dump-jump-go`. Wrapper added in syl20bnr#9792
duianto
pushed a commit
that referenced
this pull request
Jul 13, 2019
Update the existing `SPC m g g` keybinding to use the command `spacemacs/clj-find-var`. This makes finding a function definition a much better experience as you dont have to have the REPL running to find a definition, but when it is you can use a CIDER specific function. `spacemacs/clj-find-var` is a wrapper that calls `cider-find-var` if the REPL is running, otherwise it uses `dump-jump-go`. Wrapper added in #9792
kommen
added a commit
to kommen/spacemacs
that referenced
this pull request
Aug 25, 2019
`cider-jump-to-var` was renamed to `cider-find-var` here: clojure-emacs/cider@ceb2d7d#diff-e39c33031dc8d3e78b32ebee83293cd6L809-R846 In syl20bnr#9792 `spacemacs/clj-find-var` was added to be used as the jump handler for clojure modes. It uses `cider-find-var` which doesn't push jump positions onto the evil jump stack so the no longer current defadvice was more apparent.
kommen
added a commit
to kommen/spacemacs
that referenced
this pull request
Aug 25, 2019
`cider-jump-to-var` was renamed to `cider-find-var` here: clojure-emacs/cider@ceb2d7d#diff-e39c33031dc8d3e78b32ebee83293cd6L809-R846 In syl20bnr#9792 `spacemacs/clj-find-var` was added to be used as the jump handler for clojure modes. It uses `cider-find-var` which doesn't push jump positions onto the evil jump stack so the no longer current defadvice was more apparent.
smile13241324
pushed a commit
that referenced
this pull request
Aug 31, 2019
`cider-jump-to-var` was renamed to `cider-find-var` here: clojure-emacs/cider@ceb2d7d#diff-e39c33031dc8d3e78b32ebee83293cd6L809-R846 In #9792 `spacemacs/clj-find-var` was added to be used as the jump handler for clojure modes. It uses `cider-find-var` which doesn't push jump positions onto the evil jump stack so the no longer current defadvice was more apparent.
Trapez
pushed a commit
to Trapez/spacemacs
that referenced
this pull request
Sep 3, 2019
`cider-jump-to-var` was renamed to `cider-find-var` here: clojure-emacs/cider@ceb2d7d#diff-e39c33031dc8d3e78b32ebee83293cd6L809-R846 In syl20bnr#9792 `spacemacs/clj-find-var` was added to be used as the jump handler for clojure modes. It uses `cider-find-var` which doesn't push jump positions onto the evil jump stack so the no longer current defadvice was more apparent.
stephanschubert
pushed a commit
to stephanschubert/spacemacs
that referenced
this pull request
Oct 23, 2019
Update the existing `SPC m g g` keybinding to use the command `spacemacs/clj-find-var`. This makes finding a function definition a much better experience as you dont have to have the REPL running to find a definition, but when it is you can use a CIDER specific function. `spacemacs/clj-find-var` is a wrapper that calls `cider-find-var` if the REPL is running, otherwise it uses `dump-jump-go`. Wrapper added in syl20bnr#9792
stephanschubert
pushed a commit
to stephanschubert/spacemacs
that referenced
this pull request
Oct 23, 2019
`cider-jump-to-var` was renamed to `cider-find-var` here: clojure-emacs/cider@ceb2d7d#diff-e39c33031dc8d3e78b32ebee83293cd6L809-R846 In syl20bnr#9792 `spacemacs/clj-find-var` was added to be used as the jump handler for clojure modes. It uses `cider-find-var` which doesn't push jump positions onto the evil jump stack so the no longer current defadvice was more apparent.
sei40kr
pushed a commit
to sei40kr/spacemacs
that referenced
this pull request
Nov 11, 2019
Update the existing `SPC m g g` keybinding to use the command `spacemacs/clj-find-var`. This makes finding a function definition a much better experience as you dont have to have the REPL running to find a definition, but when it is you can use a CIDER specific function. `spacemacs/clj-find-var` is a wrapper that calls `cider-find-var` if the REPL is running, otherwise it uses `dump-jump-go`. Wrapper added in syl20bnr#9792
sei40kr
pushed a commit
to sei40kr/spacemacs
that referenced
this pull request
Nov 11, 2019
`cider-jump-to-var` was renamed to `cider-find-var` here: clojure-emacs/cider@ceb2d7d#diff-e39c33031dc8d3e78b32ebee83293cd6L809-R846 In syl20bnr#9792 `spacemacs/clj-find-var` was added to be used as the jump handler for clojure modes. It uses `cider-find-var` which doesn't push jump positions onto the evil jump stack so the no longer current defadvice was more apparent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improves/fixes jump-to-definition for Clojure layer
Rationale
Jump to definition in Clojure modes doesn't work reliably.
cider-find-varonly works when CIDER is connected or jacked-in and even then it doesn't always work.The idea is to use
cider-find-varwhenever possible. If it is not available, or if it fails: use the fallback option -dumb-jump-go, it is simple and it works reliably in most cases (but CIDER's fn still preferable).How to test?
g dand, g gcider-jack-ing dand, g gagain