CLI: add version command #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtrudg
approved these changes
Apr 6, 2020
There was a problem hiding this comment.
Code reads 👍 to me, and tested working with some tags.
I have a couple of minor thoughts which are really probably feature requests, and can be deferred.
- Would be nice to have the
magefile.goreport a warning if a tag object is not found, as someone is, at some point going to tag without-aand wonder why everything isunknown. - Would be nice to have the git commit set even if there is no tag and version is unknown.
Noted in #37 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve Magefile versioning. Add
versioncommand, which displays client and service version information. Fix panic insetUserAgent()whennilhttp.Transportused.