-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCI data types #301
OCI data types #301
Conversation
Codecov Report
@@ Coverage Diff @@
## main #301 +/- ##
==========================================
- Coverage 72.85% 72.67% -0.19%
==========================================
Files 35 35
Lines 2899 2953 +54
==========================================
+ Hits 2112 2146 +34
- Misses 634 648 +14
- Partials 153 159 +6
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, a few questions/comments, thank you!
78370a3
to
d84c7a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few more small things, thank you @wobito.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more nit, and one that was hidden in the last one, apologies.
a434f25
to
5fb8bf0
Compare
* add: oci blob support remove unused string * add: oci root index support * update: address pr requests * add: oci opt test * add: flag formatting * update: opts method to handle a reader Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
This PR adds 2 new datatypes in supporting #188
OCI.RootIndex
which allows the specification of the OCI image index to be addedOCI.Blob
which allows the specification of OCI artifacts to be added (blob, configs, manifests, and other indexes)