fix: delete object #327
Merged
fix: delete object #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #327 +/- ##
==========================================
- Coverage 72.78% 72.77% -0.01%
==========================================
Files 35 35
Lines 2976 2964 -12
==========================================
- Hits 2166 2157 -9
+ Misses 650 648 -2
+ Partials 160 159 -1
|
tri-adam
reviewed
Sep 19, 2023
wobito
force-pushed
the
fix-delete-object
branch
from
7c32401
to
87e47a2
Compare
tri-adam
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug was discovered while deleting an object from a SIF, where the in-memory descriptor wasn't marked as unused.
This fixes that by simplifying the process by reseting the descriptor on the memory allocation, then calling
writeDescriptorsto persist the change to the backing SIF.