oci-sif: add --keep-layers to preserve layers in OCI-SIF creation
#2273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an OCI-SIF is created explicitly with `pull`, or implicitly with `run/shell/exec/instance start`, permit the image layers to be kept intact. The new `--keep-layers` flag for these commands skips squashing images to a single layer when an OCI-SIF is created from an OCI source. This is the initial step for multi-layered OCI-SIF creation. It is not possible to execute the images. Testing will be added as we proceed to refactor a lot of image handling code to allow execution of these multi-layer images. ``` $ singularity pull --oci --keep-layers docker://golang FATAL: Image file already exists: "golang_latest.oci.sif" - will not overwrite $ singularity sif list golang_latest.oci.sif ------------------------------------------------------------------------------ ID |GROUP |LINK |SIF POSITION (start-end) |TYPE ------------------------------------------------------------------------------ 1 |1 |NONE |32176-47541680 |OCI.Blob 2 |1 |NONE |47541680-66674096 |OCI.Blob 3 |1 |NONE |66674096-124489136 |OCI.Blob 4 |1 |NONE |124489136-214961584 |OCI.Blob 5 |1 |NONE |214961584-281157040 |OCI.Blob 6 |1 |NONE |281157040-281161136 |OCI.Blob 7 |1 |NONE |281161136-281162124 |OCI.Blob 8 |1 |NONE |281162124-281163339 |OCI.Blob 9 |1 |NONE |281163339-281163580 |OCI.RootIndex ``` Fixes sylabs#2266
|
Closing - subsumed into #2274 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an OCI-SIF is created explicitly with
pull, or implicitly withrun/shell/exec/instance start, permit the image layers to be kept intact.The new
--keep-layersflag for these commands skips squashing images to a single layer when an OCI-SIF is created from an OCI source.This is the initial step for multi-layered OCI-SIF creation. It is not possible to execute the images. Testing will be added as we proceed to refactor a lot of image handling code to allow execution of these multi-layer images.
Fixes #2266