Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libraw #211

Merged
merged 27 commits into from
Oct 3, 2023
Merged

Add libraw #211

merged 27 commits into from
Oct 3, 2023

Conversation

qbnu
Copy link
Contributor

@qbnu qbnu commented Jun 18, 2023

Adds support for more RAW image formats with LibRaw. ICC profiles are supported. Requires VC++ Runtime.

Also adds some fixes to metadata:

  • GPS info can now be parsed from RAW metadata
  • GPS coordinates in degrees+decimal minutes will now be converted to degrees+minutes+seconds
  • altitudes below sea level will now be negative

Before: before After: after

ExifDisplayCtl.cpp will only display metadata from either the JPEG EXIF data or RAW metadata, but it should probably be refactored to combine metadata from both. For now RAW images won't use the JPEG data.

I couldn't test

  • 16-bit RAWs
  • RAWs with HEIF thumbnails I don't think these exist, I misremembered something I read here.
  • RAWs with PPM thumbnails, so dcraw_mod is still required for those

And I didn't

  • update MSI
  • update build scripts
  • update extras/third_party/README.md
  • add Russian translation for GetFullsizeRAW option
  • Test on XP

@qbnu qbnu marked this pull request as ready for review June 18, 2023 09:43
@DmitryScaletta
Copy link

  • add Russian translation for GetFullsizeRAW option
; Поведение для открытия RAW-файлов из списка FileEndingsRAW
; 0: открывать встроенные миниатюры
; 1: открывать полный размер
; 2: открывать миниатюры, если недоступно, то полный размер
; 3: открывать полный размер, если недоступно, то миниатюры
GetFullsizeRAW=0

@sylikc
Copy link
Owner

sylikc commented Jun 18, 2023

😍😍😍 I'll get to reviewing and testing in a few days. Thanks for making the additional documentation on what else to test.

I'm curious to read the EXIF reading code... That stuff is complicated as I tried several times to add new reading capabilities

@qbnu
Copy link
Contributor Author

qbnu commented Jun 18, 2023

When I built it (here) I tried to enable X3F support since LibRaw has it disabled by default, but I guess it didn't work. So dcraw_mod is still used to open embedded thumbnails in X3Fs.

FileEndingsRAW=*.pef;*.dng;*.crw;*.nef;*.cr2;*.mrw;*.rw2;*.orf;*.x3f;*.arw;*.kdc;*.nrw;*.dcr;*.sr2;*.raf
FileEndingsRAW=*.pef;*.dng;*.crw;*.nef;*.cr2;*.mrw;*.rw2;*.orf;*.x3f;*.arw;*.kdc;*.nrw;*.dcr;*.sr2;*.raf;*.kc2;*.erf;*.3fr;*.raw;*.mef;*.mos;*.mdc;*.cr3

; ��������� ��� �������� RAW-������ �� ������ FileEndingsRAW

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong Cyrillic letters in the first line. Should be fixed like this:

- ; Џоведение длЯ открытиЯ RAW-файлов из списка FileEndingsRAW
+ ; Поведение для открытия RAW-файлов из списка FileEndingsRAW

Probably it was an issue with windows-1251 encoding which used back in the days for languages that use Cyrillic.
Maybe it's time to finally convert these files to Unicode?

@sylikc sylikc added enhancement New feature or request format support Related to add/remove/change of a specific format support. labels Jun 23, 2023
sylikc added a commit that referenced this pull request Oct 3, 2023
Exif Metadata changes:
* GPS info can now be parsed from RAW metadata
* GPS coordinates in degrees+decimal minutes will now be converted to degrees+minutes+seconds
* altitudes below sea level will now be negative

See PR for more info

Merge PR #211 by https://github.com/qbnu
@sylikc sylikc merged commit fb2488c into sylikc:master Oct 3, 2023
4 checks passed
@sylikc
Copy link
Owner

sylikc commented Oct 3, 2023

thanks for all your work on this. I was running some tests with misc RAW files I have lying around

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request format support Related to add/remove/change of a specific format support.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants