-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add libraw #211
Add libraw #211
Conversation
; Поведение для открытия RAW-файлов из списка FileEndingsRAW
; 0: открывать встроенные миниатюры
; 1: открывать полный размер
; 2: открывать миниатюры, если недоступно, то полный размер
; 3: открывать полный размер, если недоступно, то миниатюры
GetFullsizeRAW=0 |
😍😍😍 I'll get to reviewing and testing in a few days. Thanks for making the additional documentation on what else to test. I'm curious to read the EXIF reading code... That stuff is complicated as I tried several times to add new reading capabilities |
When I built it (here) I tried to enable X3F support since LibRaw has it disabled by default, but I guess it didn't work. So dcraw_mod is still used to open embedded thumbnails in X3Fs. |
src/JPEGView/Config/JPEGView_ru.ini
Outdated
FileEndingsRAW=*.pef;*.dng;*.crw;*.nef;*.cr2;*.mrw;*.rw2;*.orf;*.x3f;*.arw;*.kdc;*.nrw;*.dcr;*.sr2;*.raf | ||
FileEndingsRAW=*.pef;*.dng;*.crw;*.nef;*.cr2;*.mrw;*.rw2;*.orf;*.x3f;*.arw;*.kdc;*.nrw;*.dcr;*.sr2;*.raf;*.kc2;*.erf;*.3fr;*.raw;*.mef;*.mos;*.mdc;*.cr3 | ||
|
||
; ��������� ��� �������� RAW-������ �� ������ FileEndingsRAW |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong Cyrillic letters in the first line. Should be fixed like this:
- ; Џоведение длЯ открытиЯ RAW-файлов из списка FileEndingsRAW
+ ; Поведение для открытия RAW-файлов из списка FileEndingsRAW
Probably it was an issue with windows-1251
encoding which used back in the days for languages that use Cyrillic.
Maybe it's time to finally convert these files to Unicode?
Exif Metadata changes: * GPS info can now be parsed from RAW metadata * GPS coordinates in degrees+decimal minutes will now be converted to degrees+minutes+seconds * altitudes below sea level will now be negative See PR for more info Merge PR #211 by https://github.com/qbnu
thanks for all your work on this. I was running some tests with misc RAW files I have lying around |
Adds support for more RAW image formats with LibRaw. ICC profiles are supported. Requires VC++ Runtime.
Also adds some fixes to metadata:
Before:
After: ![after](https://private-user-images.githubusercontent.com/93988953/246651124-5c131bd7-8311-4c39-a4aa-0679b18237eb.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA0NjIyMzEsIm5iZiI6MTcyMDQ2MTkzMSwicGF0aCI6Ii85Mzk4ODk1My8yNDY2NTExMjQtNWMxMzFiZDctODMxMS00YzM5LWE0YWEtMDY3OWIxODIzN2ViLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzA4VDE4MDUzMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTk3MjQyZmRhNGM3YzczZGMzYTVjNDlmOThhZjg3ZjEwYWYwNzgxZGZmNTM0ODg5MTU1NjY3NDA5MTNkODM5NGEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.mXgPRiTPgEjXIUuBMWTGzmmbSG8FLCWYnE_xPznBcAk)
ExifDisplayCtl.cpp will only display metadata from either the JPEG EXIF data or RAW metadata, but it should probably be refactored to combine metadata from both. For now RAW images won't use the JPEG data.
I couldn't test
RAWs with HEIF thumbnailsI don't think these exist, I misremembered something I read here.And I didn't
add Russian translation for GetFullsizeRAW option