Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle new data from UltimateGuitar tabs #6

Closed
SylvainDe opened this issue Jun 7, 2020 · 1 comment
Closed

Handle new data from UltimateGuitar tabs #6

SylvainDe opened this issue Jun 7, 2020 · 1 comment

Comments

@SylvainDe
Copy link
Owner

Visiting ultimateguitare.com recently, I had the feeling that a few things had changed (piano tabs ?).
This would not appear in my local tests as I have a cache of webpages retrieved. It may be worth trying to move the cache and check how different the new results are (is everything working properly ? are there any relevant pieces of information we could rely on ?)
@SylvainDe
Copy link
Owner Author

In fact, there is nothing really interesting that was added.
I've updated my local data - see ad8f32d .

SylvainDe added a commit that referenced this issue Jun 9, 2020
@SylvainDe
Prune details before saving in ChordsFromApplicature objects - remove…
c35410e 
… duplicates

Following recent updates of UltimateGuitar
(see #6), a few additional elements were
added to the data extracted from json and
attached to ChordsFromApplicature objects.

This would lead to some Chords objects
from GuitarTab.com to be considered as
different as they do not contain these
(unused) data. Thus, they would both
appear (the same way) in the final html
document.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SylvainDe