Kirby v4 compatibility #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- move k-table class from <table> to new wrapping <div> - remove outdated --item-height variable - top align fields so that single-line fields look nicer next to multiline fields (writer, textarea) - remove border-radius from inputs inside multilist - remove gray outline
mrflix
changed the title
This was referenced Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes now 2 compatibility adjustments: for Kirby 3.8.0 and for Kirby 4 (alpha.6). I think the adjustments for Kirby 4 break the layouts for Kirby 3.8.0.
Kirby 4.0 alpha.6
Before:
After:
Changelog
<table>to new wrapping<div>Kirby 3.8.0
I just found this broken multilist UI in a project using Kirby 3.8.0.:
Turns out that Kirby refactored the structure UI, switching from
k-structure-tableto the generick-tablewith the release of Kirby 3.7.This pull request adjusts the class names to fix the UI. It also makes the plugin incompatible with Kirby versions before 3.7.