Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Join sylvainlaurent/docker-intellij-inspect with idea-cli-inspector #1

Open
bentolor opened this issue Jan 17, 2019 · 1 comment
Open

Comments

@bentolor
Copy link

Hello @sylvainlaurent

In bentolor/idea-cli-inspector#16 you mentioned that you were working on building a Docker-based implementation for idea-cli-inspector.

Unfortunately I totally missed to keep that in mind or track your repository. Later on I realized, how much benefit user have in being able to use Docker container to run the idea inspections. Lately I struggled with very low effort and priority to create my own Docker-based version which also would be available on Docker Hub.

I got the basic things running including the first automatic builds & publishing of bentolor/idea-cli-inspector on Docker Hub. Rather by accident stumbled again over your issue and your comment that you had already done the same. Damn!

On browsing your solution I realized, that your solution is by far superior in term of implementation depth and quality. Instead of further replicating work I'd love to join forces, though I looks to me that you are no longer using/maintaining your version.

It would be great if a Docker container could help to support IDEA inspection get more traction within the CI space. My current scope / focus is to enable the Ultimate edition features so that users with valid licenses can directly use a container to inspect their changes.

Do you think it would be better to join & further enhance your solution or to port / merge our two approaches?

@bentolor bentolor changed the title Incorporate sylvainlaurent/docker-intellij-inspect into upstream idea-cli-inspector Join sylvainlaurent/docker-intellij-inspect with idea-cli-inspector Jan 17, 2019
@sylvainlaurent
Copy link
Owner

hello @bentolor !

I don't have much time to work on this, but feel free to use my work and take the bits that you want in your project. Eventually I'll close this repo when I see that your project contains docker support too!

regards
Sylvain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants