Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to specify fullpath of pom.xml as project path #16

Closed
sylvainlaurent opened this issue Jan 2, 2018 · 3 comments
Closed

Allow to specify fullpath of pom.xml as project path #16

sylvainlaurent opened this issue Jan 2, 2018 · 3 comments

Comments

@sylvainlaurent
Copy link
Contributor

Hello @bentolor ,

I find your project quite useful and I even created a docker image to run inspections more easily: https://github.com/sylvainlaurent/docker-intellij-inspect

My goal is to help running inspections on maven projects (not pure IJ projects), and until recently I thought I always had to commit many IntelliJ-specific files to VCS.
But I recently played with TeamCity and found out that you can actually specify the path to a pom.xml rather than the root of the IJ project. I observed what TeamCity actually does to launch the inspections: in such a case it does the same thing as your groovy script except that the first argument is the full path to the pom.xml.

Thus, I wonder if your groovy script could be modified to allow specifying a full path to a pom.xml rather than requiring a directory?
I also noticed that the inspection profile XML file is not required to be in .idea/inspectionProfiles, one could have it elsewhere...

Would you like me to work on a pull-request for this enhancement?

@bentolor
Copy link
Owner

bentolor commented Jan 2, 2018

Hi @sylvainlaurent

this is great! I love the idea of a docker image for easier integration of IDEA inspections into toolchains other than Teamcity.

So as far as I understand you propose the following changes:

  1. Allow to point the -r option to a parent pom.xml-file as an additional alternative instead of the default of pointing to a directory with a pre-existing .idea-configuration/directory
  2. Allow to pass absolute paths to the -p option enabling the users to use inspections file located anywhere in the file system

Sounds fine for me. I'm happy to review your pull-requests for this enhancement!

sylvainlaurent added a commit to sylvainlaurent/idea-cli-inspector that referenced this issue Jan 8, 2018
sylvainlaurent added a commit to sylvainlaurent/idea-cli-inspector that referenced this issue Jan 8, 2018
sylvainlaurent added a commit to sylvainlaurent/idea-cli-inspector that referenced this issue Jan 8, 2018
@sylvainlaurent
Copy link
Contributor Author

PR #17 created

sylvainlaurent added a commit to sylvainlaurent/idea-cli-inspector that referenced this issue Jan 10, 2018
@bentolor
Copy link
Owner

Merged. Will create a new release/tag after some more testing. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants