Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin sources don't correspond to the version that's published to the Marketplace #26

Open
ForNeVeR opened this issue Jan 20, 2021 · 0 comments

Comments

@ForNeVeR
Copy link

ForNeVeR commented Jan 20, 2021

While investigating issue #22, I've found some contradictions between version published to the Marketplace (1.0.127) and the sources in the repository.

The main difference seems to be that certain components are commented-out on GitHub:

<!-- <component>-->
<!-- <implementation-class>com.sylvanaar.idea.Lua.sdk.KahluaSdk</implementation-class>-->
<!-- </component>-->
<!-- <component>-->
<!-- <implementation-class>com.sylvanaar.idea.Lua.sdk.LuaJSdk</implementation-class>-->
<!-- </component>-->
<!--<component>-->
<!--<implementation-class>com.sylvanaar.idea.Lua.LuaLoggerManager</implementation-class>-->
<!--</component>-->

The same components are enabled in the plugin.xml of the published plugin version.

⚠Notably, disabling these components (i.e. using the version of plugin.xml from GitHub) lets the plugin to work in Rider. So maybe you really should publish a version without these components?

(namely, it's the com.sylvanaar.idea.Lua.LuaLoggerManager which causes a loading error in Rider; the reason for that is unknown yet, though is described in #27)

Another issue I've found is that build.gradle uses ideaVersion property:

version ideaVersion

This property is never defined in the repository, so one has to guess what version they should substitute to build the plugin (and I never was able to generate the same artifact as the one published on the Marketplace from the current sources).

@ForNeVeR ForNeVeR changed the title Plugin sources doesn't correspond to the version that's published to the Marketplace Plugin sources don't correspond to the version that's published to the Marketplace Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant