Fix encoding:null change

bda-research · Feb 26, 2013 · 99de83d · 99de83d
1 parent c3b3c96
commit 99de83d
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 2 deletions.
diff --git a/lib/crawler.js b/lib/crawler.js
@@ -21,7 +21,7 @@ if (!iconv) {
 }
 
 
-exports.VERSION = "0.2.3";
+exports.VERSION = "0.2.4";
 
 exports.Crawler = function(options) {
 
@@ -218,6 +218,8 @@ exports.Crawler = function(options) {
                 response.body = response.body.toString("utf8"); //hope for the best
             }
 
+        } else {
+            response.body = response.body.toString();
         }
 
         if (useCache(toQueue) && !fromCache) {
@@ -272,7 +274,7 @@ exports.Crawler = function(options) {
                     // TODO cache this
                     fs.readFile(toQueue.jQueryUrl.replace(/^file\:\/\//,""),"utf-8",function(err,jq) {
                         if (err) {
-                            toQueue.callback(e);
+                            toQueue.callback(err);
                             release(toQueue);
                         } else {
                             try {

diff --git a/test/units/simple.js b/test/units/simple.js
@@ -108,5 +108,23 @@ test("one request + user agent", function() {
 });
 
 
+test("from the readme",function() {
+
+    expect( 2 );
+
+    stop();
+
+    var c = new Crawler({
+        "maxConnections":10,
+        "callback":function(error,result,$) {
+            equal(typeof result.body, "string");
+            ok(result.body.indexOf("Google")>=0);
+            start();
+        }
+    });
+    c.queue("http://google.com");
+
+});
+
 
 /* */