Skip to content

Commit

Permalink
Fixed bug in CoreQueryRequest.buildQuery
Browse files Browse the repository at this point in the history
  • Loading branch information
vthglyk committed Jul 24, 2018
1 parent 0c4672b commit cae59bd
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ public void setShould_rank(Boolean should_rank) {
}

public String buildQuery(String symbioteCoreUrl) {
return symbioteCoreUrl + "/getResourceUrls?" + buildRequestParameters();
return symbioteCoreUrl + "/query?" + buildRequestParameters();
}

public String buildRequestParameters() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public void buildQueryTest() {
.build();

String symbioteUrl = "http://example.com";
String expectedAnswer = symbioteUrl + "/getResourceUrls?platform_id=pId&platform_name=pName&owner=owner&name=name"
String expectedAnswer = symbioteUrl + "/query?platform_id=pId&platform_name=pName&owner=owner&name=name"
+ "&id=id&description=desc&location_name=lName&location_lat=123.0&location_long=456.0&max_distance=10"
+ "&observed_property=p1+2,p2&observed_property_iri=http%3A%2F%2Ftest1%23test,http%3A%2F%2Ftest2%23test"
+ "&resource_type=type&should_rank=false";
Expand All @@ -53,22 +53,22 @@ public void buildQueryTest() {
.shouldRank(Boolean.FALSE)
.build();

expectedAnswer = symbioteUrl + "/getResourceUrls?name=name&observed_property=p1+,p2&should_rank=false";
expectedAnswer = symbioteUrl + "/query?name=name&observed_property=p1+,p2&should_rank=false";
assertEquals(expectedAnswer, coreQueryRequest.buildQuery(symbioteUrl));

coreQueryRequest = new CoreQueryRequest.Builder()
.observedProperty(Arrays.asList("p1", "p2"))
.shouldRank(Boolean.TRUE)
.build();

expectedAnswer = symbioteUrl + "/getResourceUrls?observed_property=p1,p2&should_rank=true";
expectedAnswer = symbioteUrl + "/query?observed_property=p1,p2&should_rank=true";
assertEquals(expectedAnswer, coreQueryRequest.buildQuery(symbioteUrl));

coreQueryRequest = new CoreQueryRequest.Builder()
.shouldRank(Boolean.FALSE)
.build();

expectedAnswer = symbioteUrl + "/getResourceUrls?should_rank=false";
expectedAnswer = symbioteUrl + "/query?should_rank=false";
assertEquals(expectedAnswer, coreQueryRequest.buildQuery(symbioteUrl));
}

Expand Down

0 comments on commit cae59bd

Please sign in to comment.