Adds back child html functionality, add test, and fixes json strings #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 12, 2018 16:59
Children: - Logic added back in (though refactored to better fit in). Strings: - Some strings were treated as (non existent) php contstants due to a lack of quotes.
|
@JoshuaCarter while some of this definitely looks like voodoo, it seems consistent so I can't fault anything. No issues with it being merged, just remember that it needs to come back to master somehow. |
nglasl
approved these changes
Nov 14, 2018
|
@nglasl It's all voodoo, and I am the voodoo mastah! I've got a checkbox on the card for porting to master/ss4 :) |
JoshuaCarter
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part 2 of #33 which was merged prematurely. A 1.3 release should be created for these changes.
Child HTML functionality
Inner html is processsed as it was (though refactored along with the rest of the class). It may be the case that inner html shouldn't be allowed, but for now at least it should be left in.
Test
Adds test for multiple root level properties in json data.
Json strings
Json strings were not being wrapped in quotes. PHP would identify them as undeclared constants and fallback to identifying them as a string and throw a notice. Tests throw exceptions on notice. Would eventually be an issue when a string overlapped with a constant name, etc.