Merge pull request #32 from symbiote/fix-sorting

FIX: adding credit and resolving an issue with menu_groups_alphabetical_sorting

README.md

@@ -102,10 +102,6 @@ langcode:
     Other_Label: 'translated text'
 ```
 
-## Maintainer
-
-* Marcus Nyeholt (<marcus@symbiote.com.au>)
-
 ## Requirements
 
 * SilverStripe 4.0+ (See other branches for compatibility with older versions)
@@ -114,3 +110,7 @@ langcode:
 
 * [GitHub Project Page](https://github.com/symbiote/silverstripe-grouped-cms-menu)
 * [Issue Tracker](https://github.com/symbiote/silverstripe-grouped-cms-menu/issues)
+
+## Credits
+
+* A massive thanks to Russ Michell ([phptek](https://github.com/phptek)) for upgrading this module to be SS4 compatible!

composer.json

@@ -5,10 +5,16 @@
     "homepage": "https://github.com/symbiote/silverstripe-grouped-cms-menu",
     "keywords": ["silverstripe", "menu", "module", "cms", "group", "grouped", "grouping"],
     "license": "BSD-3-Clause",
-    "authors": [{
-        "name": "Marcus Nyeholt",
-        "email": "marcus@symbiote.com.au"
-    }],
+    "authors": [
+        {
+            "name": "Marcus Nyeholt",
+            "homepage": "https://github.com/nyeholt"
+        },
+        {
+            "name": "Russ Michell",
+            "homepage": "https://github.com/phptek"
+        }
+    ],
     "require": {
         "silverstripe/admin": "~1.3"
     },

src/Admin/GroupedCmsMenu.php

@@ -188,7 +188,7 @@ public function filterChildren(SS_List $children)
         }
 
         return $config->get('menu_groups_alphabetical_sorting') ?
-                $filtered->sort('Title') :
+                $filtered->sort('ChildTitle') :
                 $filtered->sort('SortOrder');
     }