Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scheduledJob to ImmediateQueueHandler #146

Merged
merged 1 commit into from
Nov 2, 2017
Merged

Add scheduledJob to ImmediateQueueHandler #146

merged 1 commit into from
Nov 2, 2017

Conversation

dhensby
Copy link
Contributor

@dhensby dhensby commented Nov 2, 2017

This API is relied upon in QueuedJobHandler and causes fatal errors if you try to use the immediatequeuehandler.

robbieaverill
robbieaverill approved these changes Nov 2, 2017
View reviewed changes
Copy link
Contributor

@robbieaverill robbieaverill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I feel like there should be a QueueHandlerInterface to prevent this sort of thing from happening

@robbieaverill
Copy link
Contributor

PHP 5.3 failure in Travis is unrelated

@robbieaverill robbieaverill merged commit b9fc5fe into symbiote:2.8 Nov 2, 2017
@dhensby dhensby deleted the pulls/2.8/immediate-handler branch November 6, 2017 16:07
@dhensby
Copy link
Contributor Author

dhensby commented Nov 6, 2017

I feel like there should be a QueueHandlerInterface to prevent this sort of thing from happening

indeed - but adding interfaces can be considered a breaking change and so needs to go into a major release line :(

@robbieaverill robbieaverill mentioned this pull request Nov 7, 2017
Open
@robbieaverill
Copy link
Contributor

Logged for future reference as #149

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robbieaverill robbieaverill robbieaverill approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dhensby @robbieaverill