Skip to content

Commit

Permalink
FIX, cleaning up the previous google analytics implementation, since …
Browse files Browse the repository at this point in the history
…it's no longer needed.
  • Loading branch information
Nathan Glasl committed Jan 12, 2017
1 parent e7b4add commit 13318d9
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
1 change: 1 addition & 0 deletions .travis.yml
Expand Up @@ -27,6 +27,7 @@ before_script:
- cd ~/builds/ss
# These cause issues during tests.
- rm -r multisites
- rm -r multisites-googleanalytics
# This causes issues with SS 3.2 during tests.
- rm -r versionedfiles
# This causes issues with SS 3.2 and PHP 5.6 during tests.
Expand Down
4 changes: 1 addition & 3 deletions code/extensions/SISSite.php
Expand Up @@ -6,7 +6,7 @@
class SISSite extends DataExtension {

private static $db = array(
'GACode' => 'Varchar(16)',
'GACode' => 'Varchar(16)', // This remains for backward compatibility.
'FacebookURL' => 'Varchar(256)', // multitude of ways to link to Facebook accounts, best to leave it open.
'TwitterUsername' => 'Varchar(16)', // max length of Twitter username 15
'AddThisProfileID' => 'Varchar(32)'
Expand All @@ -21,8 +21,6 @@ class SISSite extends DataExtension {
);

public function updateSiteCMSFields(FieldList $fields) {
$fields->addFieldToTab('Root.Main', $gaCode = new TextField('GACode', 'Google Analytics account'));
$gaCode->setRightTitle('Account number to be used all across the site (in the format <strong>UA-XXXXX-X</strong>)');

$fields->addFieldToTab('Root.SocialMedia', $facebookURL = new TextField('FacebookURL', 'Facebook UID or username'));
$facebookURL->setRightTitle('Facebook link (everything after the "http://facebook.com/", eg http://facebook.com/<strong>username</strong> or http://facebook.com/<strong>pages/108510539573</strong>)');
Expand Down

0 comments on commit 13318d9

Please sign in to comment.