Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Co-signatory of a (2 of 3) multisig account cannot sign an aggregate bonded tx (for creating a multi-level multisig) #1350

Closed
fajarvm opened this issue Mar 20, 2021 · 3 comments · Fixed by #1595
Assignees
Labels
P2 Issue Feature or UI issue preventing an action, Incomplete process or crashing during action sprint-2

Comments

@fajarvm
Copy link

fajarvm commented Mar 20, 2021

There is a possible issue in Symbol Desktop Wallet where a multisig enabled account cannot sign an aggregate bonded transaction to become a cosignatory of a multi-level multisig account. Now, I'm not sure if this is an issue in the core code or in the desktop client.

Background:
I'm trying to setup a harvesting node on AllNodes, and as part of the process, I have to sign an aggregate bonded transaction created by an account managed by AllNodes. According to the instruction of AllNodes, I should be able to sign this transaction in Symbol Desktop Client by:

  1. Go to Home,
  2. Click on the aggregate bonded transaction, a transaction details pop-up dialog will be shown,
  3. In the transaction details pop-up dialog, click on the confirm button

The problem:
There's no "confirm" button. (See screenshot)
This transaction details is also shown for all of my cosignatory accounts; no confirmation button.

Expected behaviour:

Screenshots:
TX Hash in screenshot: C770144F3EFCC5B82F69F9C7B5DD4555798387D7D4904C276109F4512DDECFA7
If more information is needed, I'd be happy to share.

Screenshot 2021-03-20 at 16 15 45

@fajarvm fajarvm changed the title Co-signatory of a (2 od 3) multisig account cannot sign an aggregate bonded tx (for creating a multi-level multisig) Co-signatory of a (2 of 3) multisig account cannot sign an aggregate bonded tx (for creating a multi-level multisig) Mar 20, 2021
@Peersyst Peersyst added this to Issue Backlog in Symbol Desktop Wallet via automation Mar 22, 2021
@Peersyst Peersyst added the P2 Issue Feature or UI issue preventing an action, Incomplete process or crashing during action label Mar 22, 2021
@Peersyst Peersyst moved this from Issue Backlog to Pending Acceptance in Symbol Desktop Wallet Mar 23, 2021
@Peersyst Peersyst moved this from Pending Acceptance to Issue Backlog in Symbol Desktop Wallet Mar 24, 2021
@Peersyst Peersyst moved this from Issue Backlog to In sprint in Symbol Desktop Wallet Mar 26, 2021
@Peersyst Peersyst self-assigned this Mar 26, 2021
Peersyst pushed a commit that referenced this issue Apr 6, 2021
@Peersyst Peersyst linked a pull request Apr 6, 2021 that will close this issue
@Peersyst Peersyst moved this from In sprint to Feature ready for testing in Symbol Desktop Wallet Apr 6, 2021
@surekabpm
Copy link

@AdriaCarrera I created the Multi level multisig account and initiated teh aggregate transaction but i dont see any pop or any confirm button . can you please check
Test01- TB4XBSGSRDNKJKR25PX5O4X5CYCD2H2QDP75AII Test 01, 02 are multisig and 03,04 are seerate multi sig , also added 04 to first multisig )
Test02- TCLDX3DL6PUWX7FTXL7OLFVE6WVNZAOR7ILCHLQ
Test03- TDW3SS2GL3PD6CE7K6XN3VPUAQVJ6RBWQ4LCR7Q
Test04- TAW5VFRUDMXNLOVUJ7IRI4MKRJRDYBV7BYVR4HY

@surekabpm
Copy link

screenshots
image
image
image

@Peersyst Peersyst moved this from Feature ready for testing to In sprint in Symbol Desktop Wallet Apr 9, 2021
@Peersyst Peersyst removed their assignment Apr 16, 2021
@bassemmagdy bassemmagdy moved this from In sprint to Feature ready for testing in Symbol Desktop Wallet Apr 21, 2021
@postoronnii
Copy link

@bassemmagdy I still can reproduce it. I am taking one multisig account with 2co-signers (ch1, chm2), convert chm2 co-signer into multisig with 2 co-signors (ch3, ch4). Initiating transaction from ch1 and expect to receive aggregate transaction in ch3 and ch4, but unsuccessfully.
Mnemonic: obscure basic stamp regular cloth buddy kick youth silver grain tattoo common crisp arrive intact spice uncle ability lab nerve empower lion happy tuna

@surekabpm surekabpm moved this from Feature ready for testing to Ready for integration testing in Symbol Desktop Wallet Jun 22, 2021
@cryptoBeliever cryptoBeliever moved this from Ready for integration testing to Sprint 2 in Symbol Desktop Wallet Jun 22, 2021
@surekabpm surekabpm moved this from Sprint_02 Backlog to In Progress in Symbol Desktop Wallet Jul 13, 2021
bassemmagdy added a commit that referenced this issue Jul 17, 2021
bassemmagdy added a commit that referenced this issue Jul 17, 2021
bassemmagdy added a commit that referenced this issue Jul 17, 2021
@bassemmagdy bassemmagdy self-assigned this Jul 17, 2021
@bassemmagdy bassemmagdy moved this from In Progress to Code Review/Unit Test in Symbol Desktop Wallet Jul 17, 2021
@cryptoBeliever cryptoBeliever added this to Product Backlog in Wallets Jul 19, 2021
@cryptoBeliever cryptoBeliever moved this from Product Backlog to In progress in Wallets Jul 19, 2021
@bassemmagdy bassemmagdy moved this from Code Review/Unit Test to Quality Assurance in Symbol Desktop Wallet Aug 11, 2021
@bassemmagdy bassemmagdy moved this from Quality Assurance to Code Review/Unit Test in Symbol Desktop Wallet Aug 12, 2021
Symbol Desktop Wallet automation moved this from Code Review/Unit Test to Quality Assurance Aug 19, 2021
AnthonyLaw pushed a commit that referenced this issue Aug 19, 2021
* fix #1350

* update function return type

* fix sonarcloud bugs

* fix code smell

* refactor getMultisigChildren

* decrease cognitive complexity

* update sdk version

* adding unit tests

* adding docs

* remove logs

* adding unit test

* adding docs

* fix naming typo

* fix feedback issues
Wallets automation moved this from In progress to Done Aug 19, 2021
@AnthonyLaw AnthonyLaw moved this from Quality Assurance to Done in Symbol Desktop Wallet Aug 19, 2021
@surekabpm surekabpm moved this from Done to Pending Release in Symbol Desktop Wallet Aug 24, 2021
@surekabpm surekabpm moved this from Done to Pending Release in Wallets Sep 2, 2021
@cryptoBeliever cryptoBeliever moved this from Pending Release to Done in Symbol Desktop Wallet Sep 8, 2021
@coiki coiki moved this from Pending Release to Done in Wallets Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Issue Feature or UI issue preventing an action, Incomplete process or crashing during action sprint-2
Projects
5 participants