Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregate transactions get random names from the addressbook #1831

Closed
postoronnii opened this issue Jan 19, 2022 · 5 comments · Fixed by #1847
Closed

Aggregate transactions get random names from the addressbook #1831

postoronnii opened this issue Jan 19, 2022 · 5 comments · Fixed by #1847
Assignees
Labels
P2 Issue Feature or UI issue preventing an action, Incomplete process or crashing during action

Comments

@postoronnii
Copy link

WTR:

  1. Add some contacts in your addressbook
  2. Send a few aggregate transactions from the same address to yours

Result: you can see that some transactions have random names from your addressbook

On the screen below all unconfirmed aggregate transactions should have name Paul

History Page
image

Addressbook
image

image

@postoronnii postoronnii changed the title [Addressbook] Aggregate transactions getting random names from the addressbook [Addressbook] Aggregate transactions gets random names from the addressbook Jan 19, 2022
@postoronnii postoronnii changed the title [Addressbook] Aggregate transactions gets random names from the addressbook [Addressbook] Aggregate transactions get random names from the addressbook Jan 19, 2022
@bassemmagdy
Copy link
Contributor

bassemmagdy commented Jan 19, 2022

couldn't reproduce, please provide exported address book list and private key. Also, did you pull the latest updates before reproducing that issue? there was a similar display issue when filtering using blacklisted contacts, and I can see from the screenshot that you got one transaction from a whitelisted address displayed in the list while filtering -> that one should already be fixed

@bassemmagdy
Copy link
Contributor

The issue is not related to address-book changes, it's related to filters in general so we can fix that in a separate PR apart from #1814.

@postoronnii postoronnii changed the title [Addressbook] Aggregate transactions get random names from the addressbook Aggregate transactions get random names from the addressbook Jan 21, 2022
@postoronnii postoronnii added the P2 Issue Feature or UI issue preventing an action, Incomplete process or crashing during action label Jan 21, 2022
@cryptoBeliever
Copy link
Contributor

A similar problem is when I receive new bonded/unconfirmed transactions. Then looks like the name from the address book is taken from the confirmed transaction below unconfirmed:
https://share.getcloudapp.com/kpu4rD7z

@OlegMakarenko OlegMakarenko self-assigned this Feb 16, 2022
@OlegMakarenko OlegMakarenko added this to Product backlog in Symbol Desktop Wallet via automation Feb 16, 2022
@OlegMakarenko OlegMakarenko moved this from Product backlog to In Progress in Symbol Desktop Wallet Feb 16, 2022
@OlegMakarenko OlegMakarenko linked a pull request Feb 16, 2022 that will close this issue
Symbol Desktop Wallet automation moved this from In Progress to Quality Assurance Feb 17, 2022
@cryptoBeliever
Copy link
Contributor

Fixed in #1847

@cryptoBeliever
Copy link
Contributor

Released (1.0.11)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Issue Feature or UI issue preventing an action, Incomplete process or crashing during action
Projects
Symbol Desktop Wallet
  
Quality Assurance
Development

Successfully merging a pull request may close this issue.

4 participants