Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: divisibility problem for offline mode #1538

Merged
merged 2 commits into from
Jun 24, 2021
Merged

fix: divisibility problem for offline mode #1538

merged 2 commits into from
Jun 24, 2021

Conversation

AnthonyLaw
Copy link
Member

Fix

  • Because of offline mode, getter store mosaic/mosaics return empty, can't get network currency's divisibility.

Note:

  1. To test this, turn off your internet connection, clear local storage on your browser.
  2. created offline tx and download the QR code.
  3. Turn on internet and log in to your wallet.
  4. selected Import QR code and use that QR code you downloaded.

Resolved: #1473

@AnthonyLaw AnthonyLaw mentioned this pull request Jun 16, 2021
Closed
@postoronnii
Copy link

fixed

@postoronnii postoronnii reopened this Jun 22, 2021
@bassemmagdy bassemmagdy merged commit 9e74fc7 into integration Jun 24, 2021
@bassemmagdy bassemmagdy deleted the gh1473-s2-fix-offline-tx branch June 24, 2021 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bassemmagdy bassemmagdy bassemmagdy approved these changes

@AdriaCarrera AdriaCarrera Awaiting requested review from AdriaCarrera

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AnthonyLaw @postoronnii @bassemmagdy