Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

js-sha3 package #622

Open
rg911 opened this issue Jul 7, 2020 · 4 comments
Open

js-sha3 package #622

rg911 opened this issue Jul 7, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@rg911
Copy link
Contributor

rg911 commented Jul 7, 2020

There's a defect reported for js-sha3 (emn178/js-sha3#23) which can be a show stopper for some sdk users. The maintenance circle on js-sha3 seems slow. We can perhaps look for alternative libraries (e.g. https://www.npmjs.com/package/sha3) if it cannot be rectified in a timely manner

@fboucquez

@rg911 rg911 added the story-3 label Jul 15, 2020
@rg911 rg911 added this to the Release Candidate milestone Jul 15, 2020
@rg911 rg911 added this to To do in Symbol-SDK Project via automation Jul 15, 2020
@rg911 rg911 added the enhancement New feature or request label Jul 15, 2020
@codebru
Copy link

codebru commented Aug 28, 2020

A note for anyone hitting this, I had this issue when running tests in jest:

input is invalid type
      at Keccak.Object.<anonymous>.Keccak.update (node_modules/js-sha3/src/sha3.js:200:19)
      at Object.<anonymous>.exports.generateNamespaceId (node_modules/symbol-sdk/src/core/format/Utilities.ts:130:10)

But it works outside of Jest. It is not a solution but is a workaround if you need one.

@rg911 rg911 added the P4 label Feb 5, 2021
@44uk
Copy link
Contributor

44uk commented Feb 10, 2021

This is my workaround for the problem.
npm install https://github.com/Propine/js-sha3.git

@aleixmorgadas
Copy link
Contributor

I applied the solution shared by @44uk , and it worked well. I just needed to delete the node_modules folder and yarn install again.

I'm using jest for testing with TypeScript

@44uk
Copy link
Contributor

44uk commented May 22, 2021

How's it going?
My workaround is seems to be better npm install Propine/js-sha3#5ae72e8b than previous.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Symbol-SDK Project
  
Product Backlog
Development

Successfully merging a pull request may close this issue.

4 participants