You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
BIP coin id should depend on the network. Currently, in Facades, we have values for mainnet coin id (43 for NEM and 4343 for Symbol). This is invalid in the case of testnet where coin id should be 1 (as is currently used by wallets and how BIP 44 specification tells https://github.com/satoshilabs/slips/blob/master/slip-0044.md)
Expected Behaviour
For all non-mainnet networks, we should use BIP 44 coin id = 1 as described in BIP 44 specification.
problem: BIP32_COIN_ID constant contains mainnet coin id.
This can be confusing when using testnet where a different coin id should be used.
solution: Drop BIP32_COIN_ID and replace it with a bip32Path function that returns a BIP32 path
given an account id.
issues: #241, #242
problem: BIP32_COIN_ID constant contains mainnet coin id.
This can be confusing when using testnet where a different coin id should be used.
solution: Drop BIP32_COIN_ID and replace it with a bip32Path function that returns a BIP32 path
given an account id.
issues: #241, #242
Current Behaviour
Currently, SymbolFacade/NemFacade holds a static value of BIP coin id:
https://github.com/symbol/symbol/blob/dev/sdk/javascript/src/facade/SymbolFacade.js#L47
https://github.com/symbol/symbol/blob/dev/sdk/javascript/src/facade/NemFacade.js#L12
What's the problem?
BIP coin id should depend on the network. Currently, in Facades, we have values for mainnet coin id (43 for NEM and 4343 for Symbol). This is invalid in the case of testnet where coin id should be 1 (as is currently used by wallets and how BIP 44 specification tells https://github.com/satoshilabs/slips/blob/master/slip-0044.md)
Expected Behaviour
For all non-mainnet networks, we should use BIP 44 coin id = 1 as described in BIP 44 specification.
The corresponding issue for Python SDK: #241
The text was updated successfully, but these errors were encountered: