Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sdk/python] Lack of support for other networks (e.g. multiple testnets) #245

Closed
cryptoBeliever opened this issue May 30, 2022 · 0 comments · Fixed by #249
Closed

[sdk/python] Lack of support for other networks (e.g. multiple testnets) #245

cryptoBeliever opened this issue May 30, 2022 · 0 comments · Fixed by #249
Assignees
@Jaguar0625 @gimre-xymcity
Labels
sdk-python Related to the Python SDK. Status: WIP This issue or PR is a work in progress.

Comments

@cryptoBeliever
Copy link
Contributor

cryptoBeliever commented May 30, 2022 •
edited

Current Behaviour

You can create Facade (NEM and Symbol) only by a string which is the name of the network available in Network.NETWORKS.
So currently we can create only Facade 'mainnet' or 'testnet'.

https://github.com/symbol/symbol/blob/dev/sdk/python/symbolchain/facade/NemFacade.py#L22
https://github.com/symbol/symbol/blob/dev/sdk/python/symbolchain/facade/SymbolFacade.py#L39

What's the problem?

SDK user is not able to create a facade for other networks than predefined mainnet and testnet.

Expected Behaviour

SDK users should be able to use SDK for other networks. Not only predefined testnet and mainnet.

The corresponding issue for JS SDK: #246
@cryptoBeliever cryptoBeliever added Status: WIP This issue or PR is a work in progress. sdk-python Related to the Python SDK. labels May 30, 2022
@cryptoBeliever cryptoBeliever mentioned this issue May 30, 2022
Closed
Jaguar0625 added a commit that referenced this issue May 30, 2022
@Jaguar0625
[sdk]: allow facades to be constructed around arbitrary network
98ca2fd 
 problem: facades look up well known networks by name, so custom networks cannot be used
solution: allow facades to be constructed around a network object in addition to a network name

  issues: #245, #246
Jaguar0625 added a commit that referenced this issue May 30, 2022
@Jaguar0625
[sdk]: allow facades to be constructed around arbitrary network
6ceff7a 
 problem: facades look up well known networks by name, so custom networks cannot be used
solution: allow facades to be constructed around a network object in addition to a network name

  issues: #245, #246
@Jaguar0625 Jaguar0625 mentioned this issue May 30, 2022
Merged
@Jaguar0625 Jaguar0625 linked a pull request May 30, 2022 that will close this issue
[sdk]: allow facades to be constructed around arbitrary network #249
Merged
Jaguar0625 added a commit that referenced this issue May 30, 2022
@Jaguar0625
[sdk]: allow facades to be constructed around arbitrary network
cb26ccb 
 problem: facades look up well known networks by name, so custom networks cannot be used
solution: allow facades to be constructed around a network object in addition to a network name

  issues: #245, #246
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jaguar0625 Jaguar0625

@gimre-xymcity gimre-xymcity

Labels
sdk-python Related to the Python SDK. Status: WIP This issue or PR is a work in progress.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[sdk]: allow facades to be constructed around arbitrary network symbol/symbol
3 participants
@Jaguar0625 @gimre-xymcity @cryptoBeliever